-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host text update #445
Host text update #445
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add tooltip to fee item labels via app config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pass help slot from connectfieldgroup -> uformgroup
Temporary Url for review: https://strr-hosts-dev--pr-445-5p6sep24.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format address with ',' and spaces
strr-base-web/nuxt.config.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
piniaPersistedstate is old package config name
Temporary Url for review: https://strr-hosts-dev--pr-445-5p6sep24.web.app |
1 similar comment
Temporary Url for review: https://strr-hosts-dev--pr-445-5p6sep24.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add separate list item for cohost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reorder dropdown items and add tooltip to help slot for pid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Looks good to me 👍
Temporary Url for review: https://strr-hosts-dev--pr-445-5p6sep24.web.app |
const addressData = computed(() => { | ||
return [ | ||
`${props.address.street},` || [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will render incorrectly if props.address.street is undefined. Maybe I'm reading this wrong, but I think it would give 'undefined,' instead of the 'unit-number streetName'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
Temporary Url for review: https://strr-hosts-dev--pr-445-5p6sep24.web.app |
Issue:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License