Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25239 pad confirmation period #462

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

kialj876
Copy link
Collaborator

Issue:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

Signed-off-by: Kial Jinnah <[email protected]>
@kialj876 kialj876 requested review from deetz99 and dimak1 January 15, 2025 22:00
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
19.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-examiner-dev--pr-462-nlxl9oza.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-platform-dev--pr-462-ieclmb51.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-strata-hotel-dev--pr-462-ucjco9ps.web.app

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-462-jsgka7iq.web.app

Copy link
Collaborator

@dimak1 dimak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@deetz99 deetz99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me 👍

@kialj876 kialj876 merged commit 54685e5 into bcgov:main Jan 16, 2025
42 of 43 checks passed
@seeker25
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants