API - Host Strata Hotel Category #550
Conversation
shaangill025
requested review from
kris-daxiom and
thorwolpert
as code owners
| batch_op.drop_column('strata_hotel_category') | ||
|
|
||
| stratahotelcategory = postgresql.ENUM(name='stratahotelcategory') | ||
| stratahotelcategory.drop(op.get_bind(), checkfirst=True) |
There was a problem hiding this comment.
Also there is a migration that was created before that uses this. So dont drop this enum if this needs to be downgraded because the previous change will still need that
There was a problem hiding this comment.
This has been removed.
| stratahotelcategory.create(op.get_bind(), checkfirst=True) | ||
|
|
||
| with op.batch_alter_table('rental_properties', schema=None) as batch_op: | ||
| batch_op.add_column(sa.Column('strata_hotel_category', sa.Enum('FULL_SERVICE', 'MULTI_UNIT_NON_PR', 'POST_DECEMBER_2023', name='stratahotelcategory'), nullable=True)) |
There was a problem hiding this comment.
You should refer to the enum that was created above here and in the history
There was a problem hiding this comment.
Sounds good, I initially did it this way to handle potential deployment to test environment without changes from main branch [with a valid revision id change].
shaangill025
force-pushed
the
fix_25480
branch
2 times, most recently
from
7fd4cfa to
b0edc8e
Compare
|
@kris-daxiom Can I get a approval on this? |
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
shaangill025
force-pushed
the
fix_25480
branch
from
0aa8228 to
d4d564a
Compare
|
Issue:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License