API - List Applications OrderBy #569
Conversation
shaangill025
force-pushed
the
fix_application_order
branch
from
02ea06c to
1730887
Compare
shaangill025
requested review from
kris-daxiom and
thorwolpert
as code owners
|
@shaangill025 i will try to update getNext app to use the oldest Host application, thanks for flagging it. |
| @@ -167,6 +169,17 @@ def get_applications(): | |||
| name: Account-Id | |||
| required: true | |||
| type: string | |||
| - in: query | |||
There was a problem hiding this comment.
Is this the right endpoint to make the changes? I thought examiner dashboard is using search_applications. If examiner dashboard is using this they need to pass the sort order as Asc explicitly. Client UIs which uses this should still see the latest applications first
There was a problem hiding this comment.
@dimak1 shared this, both endpoints being used:
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
shaangill025
force-pushed
the
fix_application_order
branch
from
1730887 to
854b13e
Compare
|
@kris-daxiom All the requested changes are now included. |
Signed-off-by: Shaanjot Gill <[email protected]>
|
|
Temporary Url for review: https://strr-hosts-dev--pr-569-5z4s8f21.web.app |
|
@shaangill025 approve the label update. There is one unresolved comment from Leshmi. |
That initial comment has been resolved by implementing sorting support for |
Issue:
Description of changes:
Addresses @dimak1 comment:
One item is missing from the list - the logic for "get next" application that we did not finalized.
Currently, if examiner clicks 'Examine` tab or Approve/Refuse buttons, they are navigated to next application details page. The next application by default is first Host application under Full Review returned by API.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License