feat: use published bifold #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clécio Varjão <[email protected]>
Signed-off-by: Clécio Varjão <[email protected]>
Signed-off-by: Clécio Varjão <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
cvarjao
reviewed
Dec 2, 2023
| @@ -59,7 +56,6 @@ | |||
| "@aries-framework/react-hooks@^0.4.2": "patch:@aries-framework/react-hooks@npm:0.4.2#./.yarn/patches/@aries-framework-react-hooks-npm-0.4.2-84b7eb8764.patch", | |||
| "@aries-framework/[email protected]": "patch:@aries-framework/react-native@npm:0.3.3#./.yarn/patches/@aries-framework-react-native-npm-0.3.3-bb75ece22d.patch", | |||
| "@aries-framework/anoncreds@^0.4.0": "patch:@aries-framework/anoncreds@npm%3A0.4.0#./.yarn/patches/@aries-framework-anoncreds-npm-0.4.0-4d3b4e769d.patch", | |||
| "@aries-framework/[email protected]": "patch:@aries-framework/anoncreds@npm%3A0.4.0#./.yarn/patches/@aries-framework-anoncreds-npm-0.4.0-4d3b4e769d.patch", | |||
| "@aries-framework/indy-vdr@^0.4.0": "patch:@aries-framework/indy-vdr@npm%3A0.4.0#./.yarn/patches/@aries-framework-indy-vdr-npm-0.4.0-b01067562c.patch" | |||
There was a problem hiding this comment.
is this being removed by accident?
There was a problem hiding this comment.
I'm not sure what happened here. I still see @aries-framework/[email protected] and added VDR back.
There was a problem hiding this comment.
there were two anoncreds patches here, I believe one was the patch to the revocation interval that jason made, The other was a speed improvement from me when looking up the revocation registry for multiple credentials. Have the patches been combined or was one accidentally deleted?
There was a problem hiding this comment.
they appear to have been duplicates, looking at the hash
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
bryce-mcmath
reviewed
Dec 4, 2023
3 tasks
Signed-off-by: Jason C. Leach <[email protected]>
# delete all node_modules
find . -name 'node_modules' -type d -prune -exec rm -rf '{}' +
# reset lock file from main
git restore --source origin/main -- yarn.lock
# install dependencies
yarn install
Signed-off-by: Clécio Varjão <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Other than my one comment LGTM |
wadeking98
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt BC Wallet to use the
@hyperledger/aries-bifold-corepackages published to NPM.