Skip to content

Commit

Permalink
- imported updated shared date picker
Browse files Browse the repository at this point in the history
- updated breadcrumb to match header
- allow filing of continuation authorization
- cleared date picker append icon
- more WIP
  • Loading branch information
Severin Beauvais committed Sep 23, 2024
1 parent f01d9bf commit cd39947
Show file tree
Hide file tree
Showing 6 changed files with 42 additions and 16 deletions.
36 changes: 30 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@bcrs-shared-components/corp-type-module": "1.0.16",
"@bcrs-shared-components/correct-name": "1.0.55",
"@bcrs-shared-components/court-order-poa": "3.0.11",
"@bcrs-shared-components/date-picker": "1.3.1",
"@bcrs-shared-components/date-picker": "1.3.3",
"@bcrs-shared-components/document-delivery": "1.2.0",
"@bcrs-shared-components/effective-date-time": "1.1.15",
"@bcrs-shared-components/enums": "1.1.11",
Expand Down
5 changes: 2 additions & 3 deletions src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ export default class App extends Mixins(CommonMixin, DateMixin, FilingTemplateMi
const crumbs: Array<BreadcrumbIF> = [
getEntityDashboardBreadcrumb(),
{
text: this.getFilingName,
text: this.header,
to: { name: this.$route.name }
}
]
Expand Down Expand Up @@ -804,8 +804,7 @@ export default class App extends Mixins(CommonMixin, DateMixin, FilingTemplateMi
}
return
case FilingTypes.CONTINUATION_IN:
// *** TODO: try to move above logic to here
// should never get here -- already handled above
// should never get here -- already handled above

Check failure on line 807 in src/App.vue

View workflow job for this annotation

GitHub Actions / linting (20.5.1)

Expected indentation of 12 spaces but found 13
throw new Error('Invalid code path for Continuation In')
case FilingTypes.DISSOLUTION:
if (this.isEntityFirm) {
Expand Down
5 changes: 3 additions & 2 deletions src/components/ContinuationIn/ContinuationAuthorization.vue
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
:inputRules="getShowErrors ? authorizationDateRules : []"
:minDate="minAuthorizationDate"
:maxDate="getCurrentDate"
:appendIcon="null"
@emitDateSync="authorization.date = $event"
/>
</v-col>
Expand Down Expand Up @@ -214,7 +215,7 @@ export default class ExtraproRegistration extends Mixins(DocumentMixin) {
authorizationDateValid = false
fileValidity = false
customErrorMessage = ['', '', '', '', ''] // max 5 files
isFileAdded = false // *** TODO: remove this?
isFileAdded = false
/**
* The minimum date for the Authorization Date:
Expand Down Expand Up @@ -246,7 +247,7 @@ export default class ExtraproRegistration extends Mixins(DocumentMixin) {
/** Whether filing status is Change Requested. */
get isStatusChangeRequested (): boolean {
return (this.getFilingStatus === FilingStatus.CHANGE_REQUESTED) // *** TODO: remove this?
return (this.getFilingStatus === FilingStatus.CHANGE_REQUESTED)
}
/** The latest review comment. Only used when filing is in Change Requested status. */
Expand Down
7 changes: 3 additions & 4 deletions src/components/common/Actions.vue
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ export default class Actions extends Mixins(AmalgamationMixin, CommonMixin,
// @Getter(useStore) getNameRequestNumber!: string
@Getter(useStore) getSteps!: Array<any>
@Getter(useStore) isBusySaving!: boolean
@Getter(useStore) isContinuationInAuthorization!: boolean
// @Getter(useStore) isContinuationInAuthorization!: boolean
@Getter(useStore) isContinuationInFiling!: boolean
@Getter(useStore) isEntityType!: boolean
@Getter(useStore) isFilingPaying!: boolean
Expand Down Expand Up @@ -276,8 +276,6 @@ export default class Actions extends Mixins(AmalgamationMixin, CommonMixin,
* @returns a promise (ie, this is an async method)
*/
async onClickFilePay (): Promise<void> {
// *** TODO: need a special case in here for Continuation In Authorizations
// prompt step validations
this.setValidateSteps(true)
Expand Down Expand Up @@ -347,7 +345,8 @@ export default class Actions extends Mixins(AmalgamationMixin, CommonMixin,
}
const paymentToken = filingComplete?.header?.paymentToken
if (paymentToken) {
// special case for continuation in authorization -- no payment at this time
if (paymentToken || this.isContinuationInAuthorization) {
const isPaymentActionRequired: boolean = filingComplete.header?.isPaymentActionRequired
const returnUrl = sessionStorage.getItem('DASHBOARD_URL') + this.getEntityIdentifier +
`?filing_id=${this.getFilingId}`
Expand Down
3 changes: 3 additions & 0 deletions src/store/store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -755,6 +755,9 @@ export const useStore = defineStore('store', {
* TODO: Add all the remaining checks when all components are in place.
*/
isContinuationInValid (): boolean {
// *** TODO: implement this
if (this.isContinuationInAuthorization) return true

const isEffectiveDateTimeValid =
(this.getFilingStatus === FilingStatus.DRAFT) ? this.getEffectiveDateTime.valid : true
const isCertifyValid = this.getCertifyState.valid && !!this.getCertifyState.certifiedBy
Expand Down

0 comments on commit cd39947

Please sign in to comment.