15538 Fixed restoration type layout and validation issues #735
Conversation
- imported latest shared Approval Type component - fixed approval type layout - refactored approval type validation - refactored restoration type validation - fixed restoration business name layout
|
Temporary Url for review: https://business-create-dev--pr-735-kkbs1pvw.web.app SB says, try this: https://business-create-dev--pr-735-kkbs1pvw.web.app/restoration-business-name?id=BC0872082 |
| @@ -1,26 +1,24 @@ | |||
| <template> | |||
| <div id="approval-type"> | |||
| <div | |||
| class="section-container" | |||
| > | |||
There was a problem hiding this comment.
This div (and class) double-wrapped the sub-component, so wasn't needed.
| :noticeDate="getRestoration.noticeDate" | ||
| :applicationDate="getRestoration.applicationDate" | ||
| :invalidSection="invalidSection" | ||
| :validate="getShowErrors" |
There was a problem hiding this comment.
A previous fix implemented this prop to enable validation.
| @@ -33,6 +31,9 @@ import { ApprovalType as ApprovalTypeShared } from '@bcrs-shared-components/appr | |||
| } | |||
| }) | |||
| export default class ApprovalType extends Vue { | |||
| /** Whether this section is invalid. */ | |||
| @Prop({ default: false }) readonly invalidSection!: boolean | |||
There was a problem hiding this comment.
This now comes from the parent component instead of being computed here.
| <div id="restoration-type"> | ||
| <div | ||
| id="restoration-type" | ||
| :class="{ 'invalid-section': invalidSection }" |
There was a problem hiding this comment.
This was previously in the parent component, but to make this consistent with the shared ApprovalType component, I moved it here.
| box-shadow: inset 3px 0 0 $app-red; | ||
| border-top-left-radius: 0 !important; | ||
| border-bottom-left-radius: 0 !important; | ||
| } |
There was a problem hiding this comment.
This is now done in the child components (as per comment above).
There was a problem hiding this comment.
See recent comments in ticket bcgov/entity#15538 for sample screenshots.
Issue #: bcgov/entity#15538
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).