replaced Minio with Document Record Service #760
Conversation
flutistar
requested review from
severinbeauvais,
cameron-eyds and
doug-lovett
There was a problem hiding this comment.
Looks good Brandon!
I have a few questions around the state management of consumerDocumentId.
Are we storing this in state because we are using it in subsequent document requests?
ie the first POST generates the docId and we use that affiliate all the following documents to that singular docId?
If so, it makes sense in state, that being said we may want to consider that this property will need to be cleared before the Cont-In flow is launched or exited etc.
Either way, we will want to make sure this ID doesn't persist between Cont In Filings.
Edge case for sure and maybe the state IS already reset between, just wanted to call it out!
src/interfaces/store-interfaces/state-interfaces/continuation-in-state-interface.ts
Show resolved
Hide resolved
flutistar
requested review from
cameron-eyds,
JazzarKarim,
doug-lovett and
severinbeauvais
| @@ -285,14 +285,28 @@ export default class AuthorizationInformation extends Mixins(DateMixin, Document | |||
| if (!documentKey || !documentName) return // safety check | |||
|
|
|||
| this.isDownloading = true | |||
| await this.downloadDocument(documentKey, documentName).catch(error => { | |||
| const documentClass = 'CORP' | |||
There was a problem hiding this comment.
Please create an enum for document classes.
There was a problem hiding this comment.
What do you think about an enum for the document type as well? (I'd be OK with both enums in the same file, fwiw.)
| @@ -4,4 +4,5 @@ export interface AuthorizationProofIF { | |||
| fileKey: string | |||
| fileName: string | |||
| }> | |||
| consumerDocumentId?: string | |||
There was a problem hiding this comment.
Can we make this name consistent with documentServiceId (in filing-interfaces.ts and elsewhere)?
There was a problem hiding this comment.
We have both documentServiceId and consumerDocumentId as well.
Thanks
There was a problem hiding this comment.
I was thinking about this documentServiceId + documentConsumerId.
Is the first one "service id" and second one "document id"? If yes then what you have makes sense.
|
|
||
| // use beforeCreate() instead of created() to avoid type conflict with components that use this mixin | ||
| async beforeCreate (): Promise<void> { | ||
| // NB: we load the lib and worker this way to avoid a memory leak (esp in unit tests) | ||
| // NB: must use legacy build for unit tests not running in Node 18+ | ||
| this.pdfjsLib = pdfjs | ||
| this.pdfjsLib.GlobalWorkerOptions.workerSrc = await import('pdfjs-dist/legacy/build/pdf.worker.entry') | ||
| this.documentTypes = DOCUMENT_TYPES |
There was a problem hiding this comment.
For cleaner code, I think you can actually do import { DOCUMENT_TYPES as documentTypes } from ....
There was a problem hiding this comment.
I used to use documentTypes in the components that extend documentMixin and that's why I redefined documentTypes.
There was a problem hiding this comment.
My point is, instead of using a local variable to rename DOCUMENT_TYPES, you can import it with the name you want, as per my example.
Issue #: /bcgov/entity#23446
Description of changes:
AuthorizationProofcomponentUnlimitedLiabilityCorporationInformationcomponentconsumerDocumentIdBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).