Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24451 - Add the 'Fetching Data' spinner for downloading business summary and loading document lists #115

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

patrickpeinanw
Copy link
Collaborator

@patrickpeinanw patrickpeinanw commented Jan 1, 2025

*Issue:*bcgov/entity#24451

Description of changes:
Re-organize code for the loading state spinner.

  • Show "Loading Dashboard" spinner when the page is loading
  • Show "Fetching Data" when the 1) downloading a business summary and 2) loading a document list

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

@patrickpeinanw patrickpeinanw self-assigned this Jan 1, 2025
@patrickpeinanw
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

bcregistry-sre commented Jan 2, 2025

@patrickpeinanw patrickpeinanw marked this pull request as ready for review January 2, 2025 18:35
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a duplicate of business.vue, above? Do we need a duplicate?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the dashboard page uses the business.vue, and the error page uses default.vue.

default.vue should only contain the basic elements like header, breadcrumb, and footer. In my recent commit, I removed the dialog components in default.vue. But you are right, default.vue and business.vue are still very similar. @hfekete what is your thoughts on this? should we just use one layout template?

@severinbeauvais severinbeauvais changed the title Add the 'Fetching Data' spinner for downloading business summary and loading document lists 24451 Add the 'Fetching Data' spinner for downloading business summary and loading document lists Jan 2, 2025
@patrickpeinanw
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-dashboard-dev--pr-115-d5ytvfb9.web.app

@patrickpeinanw patrickpeinanw changed the title 24451 Add the 'Fetching Data' spinner for downloading business summary and loading document lists 24451 - Add the 'Fetching Data' spinner for downloading business summary and loading document lists Jan 3, 2025
* @param ms Delay to sleep, in milliseconds.
* @returns A promise to await upon.
*/
export function sleep (ms: number): Promise<void> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a note for the future, things like this, you can put in composable, then they are autoloaded and you can just use them as any inbuilt function !

Copy link
Collaborator

@hfekete hfekete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work.

@patrickpeinanw patrickpeinanw merged commit 444aa60 into bcgov:main Jan 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants