-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
24451 - Add the 'Fetching Data' spinner for downloading business summary and loading document lists #115
Conversation
…loading document lists
/gcbrun |
Temporary Url for review: https://business-dashboard-dev--pr-115-d5ytvfb9.web.app SB says, try this: https://business-dashboard-dev--pr-115-d5ytvfb9.web.app/BC0884207 |
src/layouts/default.vue
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a duplicate of business.vue, above? Do we need a duplicate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, the dashboard page uses the business.vue, and the error page uses default.vue.
default.vue should only contain the basic elements like header, breadcrumb, and footer. In my recent commit, I removed the dialog components in default.vue. But you are right, default.vue and business.vue are still very similar. @hfekete what is your thoughts on this? should we just use one layout template?
/gcbrun |
Temporary Url for review: https://business-dashboard-dev--pr-115-d5ytvfb9.web.app |
* @param ms Delay to sleep, in milliseconds. | ||
* @returns A promise to await upon. | ||
*/ | ||
export function sleep (ms: number): Promise<void> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a note for the future, things like this, you can put in composable, then they are autoloaded and you can just use them as any inbuilt function !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work.
*Issue:*bcgov/entity#24451
Description of changes:
Re-organize code for the loading state spinner.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).