-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
23968 Business Dashboard UI: implement background retry to check for latest state #117
23968 Business Dashboard UI: implement background retry to check for latest state #117
Conversation
/gcbrun |
Temporary Url for review: https://business-dashboard-dev--pr-117-n0kartyb.web.app SB says, try this: https://business-dashboard-dev--pr-117-n0kartyb.web.app/BC0885309 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something isn't working right. I tested using the preview link and I don't see the 10 x 1-second polls. I only see the 10-second polls to start. code will be updated
deleted obsolete comment |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still to do:
check unresolved comment in dashboard.vueresolvedcheck unresolved comment in business.tsresolvedupdate app versionresolvedupdate screenshotsresolved
/gcbrun |
Temporary Url for review: https://business-dashboard-dev--pr-117-n0kartyb.web.app |
/gcbrun |
Temporary Url for review: https://business-dashboard-dev--pr-117-n0kartyb.web.app |
There's a new Cypress test error above. Can you look into it? cc: @patrickpeinanw , any ideas? |
/gcbrun |
Temporary Url for review: https://business-dashboard-dev--pr-117-n0kartyb.web.app |
@Rajandeep98 the error message is "Cannot read properties of null (reading 'lastModified')". In some cases To run and debug cypress tests locally, you first build and run the app ( |
/gcbrun |
Temporary Url for review: https://business-dashboard-dev--pr-117-n0kartyb.web.app |
/gcbrun |
Temporary Url for review: https://business-dashboard-dev--pr-117-n0kartyb.web.app |
/gcbrun |
Temporary Url for review: https://business-dashboard-dev--pr-117-n0kartyb.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Can you please update the package.json version please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Merge when ready.
You're fixing the Cypress tests in a future ticket or PR, right?
re-run cypress, all tests passed |
@Rajandeep98 , thanks for merging. I forgot to tell you: use the "squash" option when merging so that your PR gets merged as a single commit instead of multiple invididual commits. |
*Issue:*bcgov/entity#23968
Description of changes:
every 1 second until the 10 second mark
every 10 seconds until the 1 minute mark
every minute until the 30 minute mark
every hour thereafter
data polling slim end point , compare it with initial /identifier api endpoint's modified date,
show toast msg if modified date vs slim endpoint modified date > 0s