24659 - Implement Withdraw Action in Ledger #119
Conversation
meawong
requested review from
hfekete,
patrickpeinanw,
severinbeauvais,
JazzarKarim,
Rajandeep98 and
ketaki-deodhar
as code owners
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-119-aql2sz14.web.app |
| @@ -167,7 +172,7 @@ const correctionFormSubmit = async function () { | |||
| filingError.value = 'Unable to get correction filing id' | |||
| return | |||
| } | |||
| const path = `/${currentBusiness.value.identifier}/correction/` | |||
| const path = `/${currentBusinessIdentifier.value}/correction/` | |||
There was a problem hiding this comment.
Please call out this fix in your ticket so that QA knows to verify this.
|
|
|
|
|
@patrickpeinanw Any idea why the setup-job check failed? |
related to: https://www.githubstatus.com/? |
confirmed with Jacqueline that the design is implemented as expected |
yes, Jacqueline confirmed that we can withdraw any FE filing |
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-119-aql2sz14.web.app |
|
@severinbeauvais I recommend reverting back to the old dependencies just like in PR #118. If you want to update the lock files, it can be done in a separate PR and we need to ensure all tests are passing locally. |
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-119-aql2sz14.web.app |
meawong
force-pushed
the
24659-Implement-Withdraw-File-Action
branch
from
022f82f to
cb83a0b
Compare
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-119-aql2sz14.web.app |
package.json
Outdated
| @@ -2,7 +2,7 @@ | |||
| "name": "bcros-business-dashboard", | |||
| "private": true, | |||
| "type": "module", | |||
| "version": "1.0.1", | |||
| "version": "1.0.2", | |||
There was a problem hiding this comment.
Please rebase again. The version is already 1.0.2.
https://github.com/bcgov/business-dashboard-ui/blob/main/package.json
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-119-aql2sz14.web.app |
*Issue:*bcgov/entity#24659
Description of changes:
Try:
Regular Businesss: https://business-dashboard-dev--pr-119-aql2sz14.web.app/BC0883803/?accountid=3627&accountid=3627
Bootstrap Business: https://business-dashboard-dev--pr-119-aql2sz14.web.app/TJes1p4Er5/?accountid=3627&accountid=3627
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).