-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
22561 Update ledger body for FE IA / Amalgamation / Continuation In / etc #124
22561 Update ledger body for FE IA / Amalgamation / Continuation In / etc #124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/gcbrun |
Temporary Url for review: https://business-dashboard-dev--pr-124-9kx34we4.web.app SB says, try this FE alteration: https://business-dashboard-dev--pr-124-9kx34we4.web.app/BC0886466?filing_id=161929 SB says, try this FE COA: https://business-dashboard-dev--pr-124-9kx34we4.web.app/BC0887059?filing_id=161931 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ledger item looks great, but the link to the form still doesn't work.
https://business-dashboard-dev--pr-124-9kx34we4.web.app/BC0886466?filing_id=161929
Hi @severinbeauvais |
Sample FE COA looks good: https://business-dashboard-dev--pr-124-9kx34we4.web.app/BC0887059?filing_id=161931 |
/gcbrun |
Temporary Url for review: https://business-dashboard-dev--pr-124-9kx34we4.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
The only thing is, can we deploy this to Prod, since the rest of the NoW work is not yet complete? Is it planned to be an Ops filing until we release everything? That's a question for Jacqueline or Mihai.
I will ask Mihai to confirm, but the only difference between the old text and the next text is that we are directing them to the paper form that they must currently fill out and submit to BC Registries for any withdrawal. So I think that we shouldn't have a problem deploying it. But once that paper form is updated, then it will ask for the filing number which I think only shows on outputs for business in the modern system. |
It's related to the feature as a whole, not specifically THIS ticket/PR. It would be in the ticket that added the drop-down menu option. If you don't see a FF check in the code for that menu option then we need to create a new ticket. Why don't you create the ticket (if needed) and I'll update it with what I know? |
Hey there! Yeah, I think the ledger items are OK, but we might want to block the "File a Withdrawal" button with a FF until the whole feature is implemented and ready to release. See my other comment above. |
I agree we wouldn't want to allow them to "file a withdrawal" until the whole feature is implemented and ready to release. |
I assume there is no FF so I created this ticket already: https://app.zenhub.com/workspaces/entities---olga-65af15f59e89f5043c2911f7/issues/gh/bcgov/entity/25406 |
*Issue:*bcgov/entity#22561
Description of changes:
Update FE ledger section
Update contact information
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).