22561 Update ledger body for FE IA / Amalgamation / Continuation In / etc

[kzdev420]

*Issue:*bcgov/entity#22561

Description of changes:

Update FE ledger section

• spacing between text
• FE section title
• language

Update contact information

• Include hours of operation

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

[JazzarKarim]

LGTM

[kzdev420]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://business-dashboard-dev--pr-124-9kx34we4.web.app

SB says, try this FE alteration: https://business-dashboard-dev--pr-124-9kx34we4.web.app/BC0886466?filing_id=161929

SB says, try this FE COA: https://business-dashboard-dev--pr-124-9kx34we4.web.app/BC0887059?filing_id=161931

[severinbeauvais]

The ledger item looks great, but the link to the form still doesn't work.

https://business-dashboard-dev--pr-124-9kx34we4.web.app/BC0886466?filing_id=161929

[kzdev420]

https://business-dashboard-dev--pr-124-9kx34we4.web.app/BC0886466?filing_id=161929

The ledger item looks great, but the link to the form still doesn't work.

Hi @severinbeauvais
It works locally.
I just checked the code at the preview URL.
It shows like this. I think It doesn't get the URL from the environment variables.

[severinbeauvais]

Sample FE COA looks good:

https://business-dashboard-dev--pr-124-9kx34we4.web.app/BC0887059?filing_id=161931

[kzdev420]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://business-dashboard-dev--pr-124-9kx34we4.web.app

[severinbeauvais]

Looks great!

The only thing is, can we deploy this to Prod, since the rest of the NoW work is not yet complete? Is it planned to be an Ops filing until we release everything? That's a question for Jacqueline or Mihai.

[severinbeauvais]

PS I don't see a Feature Flag to conditionally enable the drop-down menu option.

Am I missing something, or do we need another ticket for that?

[kzdev420]

PS I don't see a Feature Flag to conditionally enable the drop-down menu option.

Am I missing something, or do we need another ticket for that?

I didn't see that requirement on the ticket.
Did I missed it?

[jacqueline-williams-549]

Looks great!

The only thing is, can we deploy this to Prod, since the rest of the NoW work is not yet complete? Is it planned to be an Ops filing until we release everything? That's a question for Jacqueline or Mihai.

I will ask Mihai to confirm, but the only difference between the old text and the next text is that we are directing them to the paper form that they must currently fill out and submit to BC Registries for any withdrawal. So I think that we shouldn't have a problem deploying it.

But once that paper form is updated, then it will ask for the filing number which I think only shows on outputs for business in the modern system.

[severinbeauvais]

PS I don't see a Feature Flag to conditionally enable the drop-down menu option.
I didn't see that requirement on the ticket. Did I missed it?

It's related to the feature as a whole, not specifically THIS ticket/PR. It would be in the ticket that added the drop-down menu option.

If you don't see a FF check in the code for that menu option then we need to create a new ticket. Why don't you create the ticket (if needed) and I'll update it with what I know?

[severinbeauvais]

The only thing is, can we deploy this to Prod, since the rest of the NoW work is not yet complete? Is it planned to be an Ops filing until we release everything? That's a question for Jacqueline or Mihai.

I will ask Mihai to confirm, but the only difference between the old text and the next text is that we are directing them to the paper form that they must currently fill out and submit to BC Registries for any withdrawal. So I think that we shouldn't have a problem deploying it.

But once that paper form is updated, then it will ask for the filing number which I think only shows on outputs for business in the modern system.

Hey there! Yeah, I think the ledger items are OK, but we might want to block the "File a Withdrawal" button with a FF until the whole feature is implemented and ready to release.

See my other comment above.

[jacqueline-williams-549]

The only thing is, can we deploy this to Prod, since the rest of the NoW work is not yet complete? Is it planned to be an Ops filing until we release everything? That's a question for Jacqueline or Mihai.

I will ask Mihai to confirm, but the only difference between the old text and the next text is that we are directing them to the paper form that they must currently fill out and submit to BC Registries for any withdrawal. So I think that we shouldn't have a problem deploying it.
But once that paper form is updated, then it will ask for the filing number which I think only shows on outputs for business in the modern system.

Hey there! Yeah, I think the ledger items are OK, but we might want to block the "File a Withdrawal" button with a FF until the whole feature is implemented and ready to release.

See my other comment above.

I agree we wouldn't want to allow them to "file a withdrawal" until the whole feature is implemented and ready to release.

[severinbeauvais]

If you don't see a FF check in the code for that menu option then we need to create a new ticket. Why don't you create the ticket (if needed) and I'll update it with what I know?

I assume there is no FF so I created this ticket already: https://app.zenhub.com/workspaces/entities---olga-65af15f59e89f5043c2911f7/issues/gh/bcgov/entity/25406