Release branch google analytics #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 25401 - Added google analytics support * committing the lock file * fixed lint * trying to fix unit tests * trying to fix unit tests * reverted setup file change * vitest update * updated the github ci file * fixed cypress tests * updated package version
JazzarKarim
requested review from
hfekete,
patrickpeinanw,
severinbeauvais,
Rajandeep98 and
ketaki-deodhar
as code owners
severinbeauvais
approved these changes
Jan 23, 2025
JazzarKarim
merged commit 97fd883
into
bcgov:google-analytics-release-branch
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue:*bcgov/entity#25401
Description of changes:
This is just a release branch created from commit of version 1.0.5. The version here is
"version": "1.0.5b"The idea is we want those google analytics ASAP. This is the exact same commit as the latest one of mine in main.
Keep in mind, I'm merging into that release branch, not main.
I cherry picked that google analytics commit from main.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).