added FF + updated Edit UI URL (#135)

* - disabled IA correction according to FF
- moved feature flags file to utils/
- added new feature flags
- deleted obsolete code

* - added Business ID as route parameter to Edit UI URL

src/components/Dashboard/FilingHistoryList.vue

@@ -305,6 +305,7 @@
 // Libraries
 import axios from '@/axios-auth'
 import { mapGetters, mapState } from 'vuex'
+import { featureFlags } from '@/utils'
 
 // Components
 import ColinFiling from './ColinFiling.vue'
@@ -877,7 +878,7 @@ export default {
         case FilingTypes.INCORPORATION_APPLICATION:
           // redirect to Edit web app to correct this Incorporation Application
           const editUrl = sessionStorage.getItem('EDIT_URL')
-          const url = `${editUrl}correction/?filingId=${item.filingId}`
+          const url = `${editUrl}${this.entityIncNo}/correction?corrected-id=${item.filingId}`
           // assume Correct URL is always reachable
           window.location.assign(url)
           break
@@ -1085,7 +1086,12 @@ export default {
 
     /** Whether to disable correction for this history item. */
     disableCorrection (item: HistoryItemIF): boolean {
-      return (this.disableChanges || item.isCorrection || item.isFutureEffectiveIa || item.isColinFiling)
+      // feature flag code to disable correction for an Incorp App
+      const disableThisIaCorrection = (item.filingType === FilingTypes.INCORPORATION_APPLICATION &&
+        !featureFlags.getFlag('correction-ui-enabled'))
+
+      return (this.disableChanges || item.isCorrection || item.isFutureEffectiveIa || item.isColinFiling ||
+        disableThisIaCorrection)
     }
   },
 

src/components/Dashboard/TodoList.vue

@@ -421,8 +421,6 @@ import { FilingStatus, FilingTypes } from '@/enums'
 import { ANNUAL_REPORT, CORRECTION, STANDALONE_ADDRESSES, STANDALONE_DIRECTORS } from '@/constants'
 import { FilingIF, TaskItemIF } from '@/interfaces'
 
-import { featureFlags } from '@/common/FeatureFlags'
-
 export default {
   name: 'TodoList',
 

src/main.ts

@@ -7,7 +7,7 @@ import 'vuetify/dist/vuetify.min.css'
 import Vuelidate from 'vuelidate'
 import Affix from 'vue-affix'
 import Vue2Filters from 'vue2-filters' // needed by SbcFeeSummary
-import { fetchConfig } from '@/utils'
+import { fetchConfig, initLDClient } from '@/utils'
 import { getVueRouter } from '@/router'
 import { getVuexStore } from '@/store'
 import '@/registerServiceWorker'
@@ -16,7 +16,6 @@ import '@/assets/styles/layout.scss'
 import '@/assets/styles/overrides.scss'
 import KeycloakService from 'sbc-common-components/src/services/keycloak.services'
 import App from '@/App.vue'
-import { initLDClient, featureFlags } from '@/common/FeatureFlags'
 import * as Sentry from '@sentry/browser'
 import * as Integrations from '@sentry/integrations'
 
@@ -46,11 +45,6 @@ async function start () {
     await initLDClient()
   }
 
-  // if this is a draft Incorp App, check if we are allowing user to go to Create UI
-  if (sessionStorage.getItem('TEMP_REG_NUMBER') && !featureFlags.getFlag('bcrs-create-ui-enabled')) {
-    throw new Error('create-ui is disabled')
-  }
-
   // configure Keycloak Service
   console.info('Starting Keycloak service...') // eslint-disable-line no-console
   await KeycloakService.setKeycloakConfigUrl(sessionStorage.getItem('KEYCLOAK_CONFIG_PATH'))

src/common/FeatureFlags.ts → src/utils/feature-flags.ts

@@ -1,8 +1,8 @@
 import { initialize, LDFlagSet } from 'launchdarkly-js-client-sdk'
 
-/** bcrs-create-ui-enabled = whether user is allowed to go to Create UI */
 const defaultFlagSet = {
-  'bcrs-create-ui-enabled': true
+  'correction-ui-enabled': true,
+  'alteration-ui-enabled': true
 }
 
 class FeatureFlags {

src/utils/index.ts

@@ -1,2 +1,3 @@
+export * from './feature-flags'
 export * from './fetch-config'
 export * from './sleep'

src/views/Dashboard.vue

@@ -127,7 +127,6 @@ import { CoaWarningDialog } from '@/components/dialogs'
 // Enums, Constants and Interfaces
 import { EntityStatus, FilingStatus } from '@/enums'
 import { STANDALONE_ADDRESSES, STANDALONE_DIRECTORS } from '@/constants'
-import { featureFlags } from '@/common/FeatureFlags'
 import { HistoryItemIF, TaskItemIF } from '@/interfaces'
 
 export default {

tests/unit/FilingHistoryList.spec.ts

@@ -1739,6 +1739,7 @@ describe('Filing History List - redirections', () => {
     // init data
     sessionStorage.setItem('EDIT_URL', `${process.env.VUE_APP_PATH}/edit/`)
     store.state.keycloakRoles = ['staff']
+    store.state.entityIncNo = 'BC1234567'
     store.state.filings = [
       {
         filing: {
@@ -1778,7 +1779,7 @@ describe('Filing History List - redirections', () => {
     await flushPromises()
 
     // verify redirection
-    const createUrl = 'business/edit/correction/?filingId=85114'
+    const createUrl = 'business/edit/BC1234567/correction?corrected-id=85114'
     expect(window.location.assign).toHaveBeenCalledWith(createUrl)
 
     wrapper.destroy()