25190 - Court Order Filings #714
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
package-lock.json
Outdated
There was a problem hiding this comment.
For some reason, your package process added several packages that we don't need.
In this file, I expect to see only the updated package version number and the updated enums package.
Please resolve this. We do not need and should not have those additional esbuild dependencies.
Eg,
Etc.
| openFileDialog () { | ||
| // Access the underlying file input element and trigger click | ||
| const fileInput = this.$refs.fileUploadRef.$el.querySelector('input') |
There was a problem hiding this comment.
Oh, so you're not using the new file uploader component?
How about moving this code to a public function in the file upload component, that you just call here?
Reason: this component should not know what's inside the file upload component.
There was a problem hiding this comment.
You didn't fix this here so it will have to be updated later.
| readonly PageSizes = PageSizes | ||
| // enum for template | ||
| readonly FilingCodes = FilingCodes | ||
| /** Prop to display the dialog. */ |
There was a problem hiding this comment.
Are any of these props needed? If not, please replace remove them.
There was a problem hiding this comment.
You didn't fix this here so it will have to be updated later. (Ideally, when you write the unit tests.)
|
I see no unit tests in this PR. Please create another ticket to create a unit test suite for this filing. |
|
/gcbrun |
|
There was a problem hiding this comment.
In the package lock file, I see those new architecture packages. Are you using only "npm" in this repo to manage dependencies? Anyways, let's merge this and see if it's OK as-is.
PS Did you create a new ticket to write unit tests for this new filing?
Approving.
Issue #: bcgov/entity#25190
Description of changes:
Court Order Filings Added
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).