chore: implement code review, fix user roles, fix operator_designated…

…_operation_timeline to reflect realistic user, fix facility bcghg_id distribution
bcgov · Jan 15, 2025 · 320a3f0 · 320a3f0
1 parent c2f3d72
commit 320a3f0
Show file tree

Hide file tree

Showing 5 changed files with 66 additions and 66 deletions.
diff --git a/bc_obps/registration/fixtures/mock/bc_obps_regulated_operation.json b/bc_obps/registration/fixtures/mock/bc_obps_regulated_operation.json
@@ -2,15 +2,15 @@
   {
     "model": "registration.bcobpsregulatedoperation",
     "fields": {
-      "id": "21-0001",
+      "id": "23-0001",
       "issued_at": "2023-10-13T15:27:00.000Z",
       "comments": "Test comment"
     }
   },
   {
     "model": "registration.bcobpsregulatedoperation",
     "fields": {
-      "id": "21-0002",
+      "id": "23-0002",
       "issued_at": "2023-10-13T15:27:00.000Z",
       "comments": "Test comment"
     }
@@ -19,127 +19,127 @@
     "model": "registration.bcobpsregulatedoperation",
     "fields": {
       "id": "24-0003",
-      "issued_at": "2023-10-13T15:27:00.000Z",
+      "issued_at": "2024-10-13T15:27:00.000Z",
       "comments": "Test comment"
     }
   },
   {
     "model": "registration.bcobpsregulatedoperation",
     "fields": {
       "id": "24-0004",
-      "issued_at": "2023-10-13T15:27:00.000Z",
+      "issued_at": "2024-10-13T15:27:00.000Z",
       "comments": "Test comment"
     }
   },
   {
     "model": "registration.bcobpsregulatedoperation",
     "fields": {
       "id": "24-0005",
-      "issued_at": "2023-10-13T15:27:00.000Z",
+      "issued_at": "2024-10-13T15:27:00.000Z",
       "comments": "Test comment"
     }
   },
   {
     "model": "registration.bcobpsregulatedoperation",
     "fields": {
       "id": "24-0006",
-      "issued_at": "2023-10-13T15:27:00.000Z",
+      "issued_at": "2024-10-13T15:27:00.000Z",
       "comments": "Test comment"
     }
   },
   {
     "model": "registration.bcobpsregulatedoperation",
     "fields": {
       "id": "24-0007",
-      "issued_at": "2023-10-13T15:27:00.000Z",
+      "issued_at": "2024-10-13T15:27:00.000Z",
       "comments": "Test comment"
     }
   },
   {
     "model": "registration.bcobpsregulatedoperation",
     "fields": {
       "id": "24-0008",
-      "issued_at": "2023-10-13T15:27:00.000Z",
+      "issued_at": "2024-10-13T15:27:00.000Z",
       "comments": "Test comment"
     }
   },
   {
     "model": "registration.bcobpsregulatedoperation",
     "fields": {
       "id": "24-0009",
-      "issued_at": "2023-10-13T15:27:00.000Z",
+      "issued_at": "2024-10-13T15:27:00.000Z",
       "comments": "Test comment"
     }
   },
   {
     "model": "registration.bcobpsregulatedoperation",
     "fields": {
       "id": "24-0010",
-      "issued_at": "2023-10-13T15:27:00.000Z",
+      "issued_at": "2024-10-13T15:27:00.000Z",
       "comments": "Test comment"
     }
   },
   {
     "model": "registration.bcobpsregulatedoperation",
     "fields": {
       "id": "24-0011",
-      "issued_at": "2023-10-13T15:27:00.000Z",
+      "issued_at": "2024-10-13T15:27:00.000Z",
       "comments": "Test comment"
     }
   },
   {
     "model": "registration.bcobpsregulatedoperation",
     "fields": {
       "id": "24-0012",
-      "issued_at": "2023-10-13T15:27:00.000Z",
+      "issued_at": "2024-10-13T15:27:00.000Z",
       "comments": "Test comment"
     }
   },
   {
     "model": "registration.bcobpsregulatedoperation",
     "fields": {
       "id": "24-0013",
-      "issued_at": "2023-10-13T15:27:00.000Z",
+      "issued_at": "2024-10-13T15:27:00.000Z",
       "comments": "Test comment"
     }
   },
   {
     "model": "registration.bcobpsregulatedoperation",
     "fields": {
       "id": "24-0014",
-      "issued_at": "2023-10-13T15:27:00.000Z",
+      "issued_at": "2024-10-13T15:27:00.000Z",
       "comments": "Test comment"
     }
   },
   {
     "model": "registration.bcobpsregulatedoperation",
     "fields": {
       "id": "24-0015",
-      "issued_at": "2023-10-13T15:27:00.000Z",
+      "issued_at": "2024-10-13T15:27:00.000Z",
       "comments": "Test comment"
     }
   },
   {
     "model": "registration.bcobpsregulatedoperation",
     "fields": {
       "id": "24-0016",
-      "issued_at": "2023-10-13T15:27:00.000Z",
+      "issued_at": "2024-10-13T15:27:00.000Z",
       "comments": "Test comment"
     }
   },
   {
     "model": "registration.bcobpsregulatedoperation",
     "fields": {
       "id": "24-0017",
-      "issued_at": "2023-10-13T15:27:00.000Z",
+      "issued_at": "2024-10-13T15:27:00.000Z",
       "comments": "Test comment"
     }
   },
   {
     "model": "registration.bcobpsregulatedoperation",
     "fields": {
       "id": "24-0018",
-      "issued_at": "2023-10-13T15:27:00.000Z",
+      "issued_at": "2024-10-13T15:27:00.000Z",
       "comments": "Test comment"
     }
   }

diff --git a/bc_obps/registration/fixtures/mock/facility.json b/bc_obps/registration/fixtures/mock/facility.json
@@ -48,8 +48,7 @@
       "created_at": "2024-06-05T23:18:07.664Z",
       "name": "Facility 4",
       "type": "Small Aggregate",
-      "swrs_facility_id": 1004,
-      "bcghg_id": "13219990008"
+      "swrs_facility_id": 1004
     }
   },
   {
@@ -61,7 +60,6 @@
       "name": "Facility 5",
       "type": "Large Facility",
       "swrs_facility_id": 1005,
-      "bcghg_id": "13219990009",
       "latitude_of_largest_emissions": 43.5,
       "longitude_of_largest_emissions": -123.5
     }
@@ -75,7 +73,6 @@
       "name": "Facility 6",
       "type": "Large Facility",
       "swrs_facility_id": 1006,
-      "bcghg_id": "13219990010",
       "latitude_of_largest_emissions": 43.5,
       "longitude_of_largest_emissions": -123.5
     }
@@ -89,7 +86,6 @@
       "name": "Facility 7",
       "type": "Large Facility",
       "swrs_facility_id": 1007,
-      "bcghg_id": "13219990011",
       "latitude_of_largest_emissions": 43.5,
       "longitude_of_largest_emissions": -123.5
     }
@@ -243,7 +239,6 @@
       "name": "Facility 18",
       "type": "Large Facility",
       "swrs_facility_id": 1018,
-      "bcghg_id": "13219990022",
       "latitude_of_largest_emissions": 43.5,
       "longitude_of_largest_emissions": -123.5
     }
@@ -271,7 +266,6 @@
       "name": "Facility 20",
       "type": "Large Facility",
       "swrs_facility_id": 1020,
-      "bcghg_id": "13219990024",
       "latitude_of_largest_emissions": 43.5,
       "longitude_of_largest_emissions": -123.5
     }
@@ -285,7 +279,6 @@
       "name": "Facility 21",
       "type": "Large Facility",
       "swrs_facility_id": 1021,
-      "bcghg_id": "13219990025",
       "latitude_of_largest_emissions": 43.5,
       "longitude_of_largest_emissions": -123.5
     }
@@ -420,6 +413,7 @@
       "name": "Facility 31",
       "type": "Single Facility",
       "swrs_facility_id": 1031,
+      "bcghg_id": "13219990025",
       "latitude_of_largest_emissions": 43.5,
       "longitude_of_largest_emissions": -123.5
     }
@@ -433,6 +427,7 @@
       "type": "Single Facility",
       "name": "Facility 32",
       "swrs_facility_id": 1032,
+      "bcghg_id": "13219990022",
       "latitude_of_largest_emissions": 43.5,
       "longitude_of_largest_emissions": -123.5
     }
@@ -446,6 +441,7 @@
       "name": "Facility 33",
       "type": "Single Facility",
       "swrs_facility_id": 1033,
+      "bcghg_id": "13219990009",
       "latitude_of_largest_emissions": 43.5,
       "longitude_of_largest_emissions": -123.5
     }
@@ -459,6 +455,7 @@
       "name": "Facility 34",
       "type": "Single Facility",
       "swrs_facility_id": 1034,
+      "bcghg_id": "13219990008",
       "latitude_of_largest_emissions": 43.5,
       "longitude_of_largest_emissions": -123.5
     }
@@ -472,6 +469,7 @@
       "name": "Facility 35",
       "type": "Single Facility",
       "swrs_facility_id": 1035,
+      "bcghg_id": "13219990024",
       "latitude_of_largest_emissions": 43.5,
       "longitude_of_largest_emissions": -123.5
     }

diff --git a/bc_obps/registration/fixtures/mock/operation.json b/bc_obps/registration/fixtures/mock/operation.json
@@ -72,7 +72,7 @@
       "bcghg_id": "23219990003",
       "regulated_products": [2, 6, 7, 8],
       "status": "Registered",
-      "bc_obps_regulated_operation": "21-0001",
+      "bc_obps_regulated_operation": "23-0001",
       "created_at": "2024-1-31T15:27:00.000Z",
       "activities": [1, 3],
       "contacts": [14, 15],
@@ -94,7 +94,7 @@
       "bcghg_id": "23219990002",
       "regulated_products": [1],
       "status": "Registered",
-      "bc_obps_regulated_operation": "21-0002",
+      "bc_obps_regulated_operation": "23-0002",
       "created_at": "2024-1-30T15:27:00.000Z",
       "activities": [1, 5],
       "contacts": [10, 11, 12],