Skip to content

Commit

Permalink
chore: implement code review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
@fviduya
fviduya committed Jan 14, 2025
1 parent ea5c67a commit 3b4f50b
Show file tree
Hide file tree
Showing 7 changed files with 288 additions and 194 deletions.
32 changes: 16 additions & 16 deletions bc_obps/registration/fixtures/mock/bc_obps_regulated_operation.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,127 +18,127 @@
{
"model": "registration.bcobpsregulatedoperation",
"fields": {
"id": "21-0003",
"id": "24-0003",
"issued_at": "2023-10-13T15:27:00.000Z",
"comments": "Test comment"
}
},
{
"model": "registration.bcobpsregulatedoperation",
"fields": {
"id": "21-0004",
"id": "24-0004",
"issued_at": "2023-10-13T15:27:00.000Z",
"comments": "Test comment"
}
},
{
"model": "registration.bcobpsregulatedoperation",
"fields": {
"id": "21-0005",
"id": "24-0005",
"issued_at": "2023-10-13T15:27:00.000Z",
"comments": "Test comment"
}
},
{
"model": "registration.bcobpsregulatedoperation",
"fields": {
"id": "21-0006",
"id": "24-0006",
"issued_at": "2023-10-13T15:27:00.000Z",
"comments": "Test comment"
}
},
{
"model": "registration.bcobpsregulatedoperation",
"fields": {
"id": "21-0007",
"id": "24-0007",
"issued_at": "2023-10-13T15:27:00.000Z",
"comments": "Test comment"
}
},
{
"model": "registration.bcobpsregulatedoperation",
"fields": {
"id": "21-0008",
"id": "24-0008",
"issued_at": "2023-10-13T15:27:00.000Z",
"comments": "Test comment"
}
},
{
"model": "registration.bcobpsregulatedoperation",
"fields": {
"id": "21-0009",
"id": "24-0009",
"issued_at": "2023-10-13T15:27:00.000Z",
"comments": "Test comment"
}
},
{
"model": "registration.bcobpsregulatedoperation",
"fields": {
"id": "21-0010",
"id": "24-0010",
"issued_at": "2023-10-13T15:27:00.000Z",
"comments": "Test comment"
}
},
{
"model": "registration.bcobpsregulatedoperation",
"fields": {
"id": "21-0011",
"id": "24-0011",
"issued_at": "2023-10-13T15:27:00.000Z",
"comments": "Test comment"
}
},
{
"model": "registration.bcobpsregulatedoperation",
"fields": {
"id": "21-0012",
"id": "24-0012",
"issued_at": "2023-10-13T15:27:00.000Z",
"comments": "Test comment"
}
},
{
"model": "registration.bcobpsregulatedoperation",
"fields": {
"id": "21-0013",
"id": "24-0013",
"issued_at": "2023-10-13T15:27:00.000Z",
"comments": "Test comment"
}
},
{
"model": "registration.bcobpsregulatedoperation",
"fields": {
"id": "21-0014",
"id": "24-0014",
"issued_at": "2023-10-13T15:27:00.000Z",
"comments": "Test comment"
}
},
{
"model": "registration.bcobpsregulatedoperation",
"fields": {
"id": "21-0015",
"id": "24-0015",
"issued_at": "2023-10-13T15:27:00.000Z",
"comments": "Test comment"
}
},
{
"model": "registration.bcobpsregulatedoperation",
"fields": {
"id": "21-0016",
"id": "24-0016",
"issued_at": "2023-10-13T15:27:00.000Z",
"comments": "Test comment"
}
},
{
"model": "registration.bcobpsregulatedoperation",
"fields": {
"id": "21-0017",
"id": "24-0017",
"issued_at": "2023-10-13T15:27:00.000Z",
"comments": "Test comment"
}
},
{
"model": "registration.bcobpsregulatedoperation",
"fields": {
"id": "21-0018",
"id": "24-0018",
"issued_at": "2023-10-13T15:27:00.000Z",
"comments": "Test comment"
}
Expand Down
19 changes: 0 additions & 19 deletions bc_obps/registration/fixtures/mock/facility.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,6 @@
"name": "Facility 25",
"type": "Single Facility",
"swrs_facility_id": 1025,
"bcghg_id": "13219990028",
"latitude_of_largest_emissions": 43.5,
"longitude_of_largest_emissions": -123.5
}
Expand All @@ -358,7 +357,6 @@
"name": "Facility 26",
"type": "Single Facility",
"swrs_facility_id": 1026,
"bcghg_id": "13219990029",
"latitude_of_largest_emissions": 43.5,
"longitude_of_largest_emissions": -123.5
}
Expand All @@ -372,7 +370,6 @@
"name": "Facility 27",
"type": "Single Facility",
"swrs_facility_id": 1027,
"bcghg_id": "13219990030",
"latitude_of_largest_emissions": 43.5,
"longitude_of_largest_emissions": -123.5
}
Expand All @@ -386,7 +383,6 @@
"name": "Facility 28",
"type": "Single Facility",
"swrs_facility_id": 1028,
"bcghg_id": "13219990031",
"latitude_of_largest_emissions": 43.5,
"longitude_of_largest_emissions": -123.5
}
Expand All @@ -400,7 +396,6 @@
"name": "Facility 29",
"type": "Single Facility",
"swrs_facility_id": 1029,
"bcghg_id": "13219990032",
"latitude_of_largest_emissions": 43.5,
"longitude_of_largest_emissions": -123.5
}
Expand All @@ -414,7 +409,6 @@
"name": "Facility 30",
"type": "Single Facility",
"swrs_facility_id": 1030,
"bcghg_id": "13219990033",
"latitude_of_largest_emissions": 43.5,
"longitude_of_largest_emissions": -123.5
}
Expand All @@ -428,7 +422,6 @@
"name": "Facility 31",
"type": "Single Facility",
"swrs_facility_id": 1031,
"bcghg_id": "13219990034",
"latitude_of_largest_emissions": 43.5,
"longitude_of_largest_emissions": -123.5
}
Expand All @@ -442,7 +435,6 @@
"type": "Single Facility",
"name": "Facility 32",
"swrs_facility_id": 1032,
"bcghg_id": "13219990035",
"latitude_of_largest_emissions": 43.5,
"longitude_of_largest_emissions": -123.5
}
Expand All @@ -456,7 +448,6 @@
"name": "Facility 33",
"type": "Single Facility",
"swrs_facility_id": 1033,
"bcghg_id": "13219990036",
"latitude_of_largest_emissions": 43.5,
"longitude_of_largest_emissions": -123.5
}
Expand All @@ -470,7 +461,6 @@
"name": "Facility 34",
"type": "Single Facility",
"swrs_facility_id": 1034,
"bcghg_id": "13219990037",
"latitude_of_largest_emissions": 43.5,
"longitude_of_largest_emissions": -123.5
}
Expand All @@ -484,7 +474,6 @@
"name": "Facility 35",
"type": "Single Facility",
"swrs_facility_id": 1035,
"bcghg_id": "13219990038",
"latitude_of_largest_emissions": 43.5,
"longitude_of_largest_emissions": -123.5
}
Expand All @@ -498,7 +487,6 @@
"name": "Facility 36",
"type": "Single Facility",
"swrs_facility_id": 1036,
"bcghg_id": "13219990039",
"latitude_of_largest_emissions": 43.5,
"longitude_of_largest_emissions": -123.5
}
Expand All @@ -512,7 +500,6 @@
"name": "Facility 37",
"type": "Single Facility",
"swrs_facility_id": 1037,
"bcghg_id": "13219990040",
"latitude_of_largest_emissions": 43.5,
"longitude_of_largest_emissions": -123.5
}
Expand All @@ -526,7 +513,6 @@
"name": "Facility 38",
"type": "Single Facility",
"swrs_facility_id": 1038,
"bcghg_id": "13219990041",
"latitude_of_largest_emissions": 43.5,
"longitude_of_largest_emissions": -123.5
}
Expand All @@ -540,7 +526,6 @@
"name": "Facility 39",
"type": "Single Facility",
"swrs_facility_id": 1039,
"bcghg_id": "13219990042",
"latitude_of_largest_emissions": 43.5,
"longitude_of_largest_emissions": -123.5
}
Expand All @@ -554,7 +539,6 @@
"name": "Facility 40",
"type": "Single Facility",
"swrs_facility_id": 1040,
"bcghg_id": "13219990043",
"latitude_of_largest_emissions": 43.5,
"longitude_of_largest_emissions": -123.5
}
Expand All @@ -568,7 +552,6 @@
"name": "Facility 41",
"type": "Single Facility",
"swrs_facility_id": 1041,
"bcghg_id": "13219990044",
"latitude_of_largest_emissions": 43.5,
"longitude_of_largest_emissions": -123.5
}
Expand All @@ -582,7 +565,6 @@
"name": "Facility 42",
"type": "Single Facility",
"swrs_facility_id": 1042,
"bcghg_id": "13219990045",
"latitude_of_largest_emissions": 43.5,
"longitude_of_largest_emissions": -123.5
}
Expand All @@ -596,7 +578,6 @@
"name": "Facility 43",
"type": "Single Facility",
"swrs_facility_id": 1043,
"bcghg_id": "13219990046",
"latitude_of_largest_emissions": 43.5,
"longitude_of_largest_emissions": -123.5
}
Expand Down
6 changes: 3 additions & 3 deletions bc_obps/registration/fixtures/mock/facility_designated_operation_timeline.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@
"created_by": "00000000-0000-0000-0000-000000000001",
"created_at": "2024-06-20T23:20:02Z",
"facility": "67fd8288-422b-43d3-a9b1-e4ddc54e2139",
"operation": "c0743c09-82fa-4186-91aa-4b5412e3415c",
"operation": "df62d793-8cfe-4272-a93e-ea9c9139ff82",
"start_date": "2024-06-28T23:20:02Z"
}
},
Expand All @@ -256,7 +256,7 @@
{
"model": "registration.facilitydesignatedoperationtimeline",
"fields": {
"created_by": "00000000-0000-0000-0000-000000000001",
"created_by": "00000000-0000-0000-0000-000000000004",
"created_at": "2024-06-20T23:20:02Z",
"facility": "f4eb89dd-e081-4576-8663-b789c4a20478",
"operation": "d99725a7-1c3a-47cb-a59b-e2388ce0fa18",
Expand All @@ -266,7 +266,7 @@
{
"model": "registration.facilitydesignatedoperationtimeline",
"fields": {
"created_by": "00000000-0000-0000-0000-000000000001",
"created_by": "00000000-0000-0000-0000-000000000004",
"created_at": "2024-06-20T23:20:02Z",
"facility": "6d564423-abfe-4579-ba92-2c6c71c37bb9",
"operation": "436dd99a-cb41-4494-91c9-98ab149b557d",
Expand Down
Loading

0 comments on commit 3b4f50b

Please sign in to comment.