-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1734 registration2 ci cd #1758
Merged
Merged
1734 registration2 ci cd #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcellmueller
force-pushed
the
1734-registration2-ci-cd
branch
30 times, most recently
from
June 10, 2024 15:00
3b5c1ad
to
81b1498
Compare
marcellmueller
force-pushed
the
1734-registration2-ci-cd
branch
from
June 28, 2024 14:49
0937760
to
30a92a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1734
/bciers/registration
. I added some updates from fix: docker build issues #1856 and Sonarcloud is flagging thechown
commands forMake sure no write permissions are assigned to the executable.
which needs reviewThis can't be merged without updating the branch protections first. As you can see at the bottom of this PR, renaming the jobs broke required status protection and they are all stuck on
Expected — Waiting for status to be reported
.This also includes a pretty hefty reorganization of our GitHub Actions pipeline. Most of our jobs including our build steps were in
test.yaml
and it was getting rather large and needed to be split up. This will just be part 1 of our pipeline reorganization and a good starting base to break up jobs and optimize CI going forward.main.yaml
which orchestrates all workflowsmain.yaml
run-backend
action. Currently the backend test starts up the entire app including the front end which is unnecessary.nx-app-build
that builds and pushes a docker image for our nx projects with just a few env vars/inputs. The backend docker build was different enough and is unique so it stays the same.main.yaml
so we don't see separate actions for each push when clicking theActions
tab which was always confusing when trying to debug issues through prior workflows. Now they appear as a job in the main workflow.test-code.yaml
is for tests that don't require containers to be built first and can run immediately.test-e2e.yaml
which can be called when the backend image andregistration1
image is built. We can add more required jobs forregistration
andreporting
as we set up e2e for those projects.