Chore/compliance summary tests #2597
Conversation
dleard
commented
Dec 16, 2024
•
dleard
commented
- Unit tests for the static functions in the compliance summary service
- Multiple test cases for the class function in the compliance summary service
- Refactors the service to not depend on the ninja schemas for data shaping
- Fixes a bug in the compliance service where the Reduction Factor & Tightening Rate were being applied in the wrong place
dleard
force-pushed
the
chore/compliance-summary-tests
branch
2 times, most recently
from
4436252 to
1cab204
Compare
dleard
force-pushed
the
chore/compliance-summary-tests
branch
4 times, most recently
from
eb26a16 to
58d7d32
Compare
dleard
force-pushed
the
chore/compliance-summary-tests
branch
3 times, most recently
from
a713a6b to
d2f628e
Compare
dleard
force-pushed
the
chore/compliance-summary-tests
branch
from
36fca1d to
8f2985b
Compare
| reporting_only_emissions: Decimal | int, | ||
| emissions_attributable_for_compliance: Decimal | int, | ||
| emissions_limit: Decimal | int, | ||
| excess_emissions: Decimal | int, |
There was a problem hiding this comment.
is the int necessary? Wouldn't that be covered under the Decimal already?
| @classmethod | ||
| def pare_data_single_product_flaring(cls): | ||
| # Pare down build data to data needed for this test | ||
| ReportProductEmissionAllocation.objects.exclude(emission_category_id=1).delete() |
There was a problem hiding this comment.
this might have side-effects on other tests, or on other things the user of this infrastructure may do.
I'd suggest cls.allocation_1.delete() instead
...same for the ones down below
There was a problem hiding this comment.
This definitely ended up being cleaner & removed potential side effects, but what I did was I moved the .build() call inside this function instead of inside the test, delete from that instantiation & returned the new object
| reporting_window_end='2026-12-31 16:00:00-08', | ||
| report_due_date='2025-05-31 16:59:59.999-07', | ||
| ) | ||
| report = Report.objects.get(reporting_year_id=2024) |
There was a problem hiding this comment.
same, probably cls.report_1.reporting_year = ... would work better
| operation.naics_code_id = 22 | ||
| operation.save() | ||
| report.reporting_year_id = 2024 | ||
| report.save() |
There was a problem hiding this comment.
For shorter syntax we can use the update queryset method:
Report.objects.filter(pk=...).update(reporting_year_id=2024)
dleard
force-pushed
the
chore/compliance-summary-tests
branch
from
6eb3e1b to
41486f9
Compare
dleard
force-pushed
the
chore/compliance-summary-tests
branch
from
41486f9 to
fdab5dd
Compare
