Bump React component library dependencies #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass @typescript-eslint/no-empty-object-type
mkernohanbc
approved these changes
Aug 22, 2024
mkernohanbc
pushed a commit
that referenced
this pull request
Aug 23, 2024
…ry-deps Bump React component library dependencies
mkernohanbc
added a commit
that referenced
this pull request
Aug 23, 2024
…nt-library-deps" This reverts commit 60c564b.
Merged
mkernohanbc
added a commit
that referenced
this pull request
Sep 11, 2024
* scaffolding Checkbox and CheckboxGroup components * roughing out component styling * component styling * isSelected and isIndeterminate state handling * roughing out CheckboxGroup * refining Checkbox and CheckboxGroup styling * CheckboxGroup error handling * fiddling with styling * slow, grinding progress * fix isSelected/isIndeterminate styling collision * required and error handling * stories and docs * cleaning up checkbox and label positioning * fleshing out checkbox stories and docs * add selected + invalid style * expanding checkboxgroup docs and stories * further docs and stories expansion * Merge pull request #468 from bcgov/feature/bump-react-component-library-deps Bump React component library dependencies * Revert "Merge pull request #468 from bcgov/feature/bump-react-component-library-deps" This reverts commit 60c564b. * update Checkbox to use 3.1.0 tokens * Add controlled checkbox example to Vite kitchensink app * Move cursor CSS rules to Checkbox container (label) component * Fix typos in Checkbox stories * Disabled Checkbox label gets disabled font color * Add Checkbox styling for isDisabled + isIndeterminate state * Add Checkbox styling for isIndeterminate + isInvalid state * Change Checkbox flex container gap to 10px to match current design * Update Checkbox border styles for current design * Remove extended interface from Checkbox component * Remove children prop from CheckboxGroupProps interface in favor of children from ReactAriaCheckboxGroupProps * Add flexWrap prop to CheckboxGroup to allow wrapping * Add isInvalid and isSelected args to Checkbox story meta object * Add failing tests for Checkbox * Make tests for Checkbox pass by adding explicit type information to render props * Add failing tests for CheckboxGroup * Make tests for CheckboxGroup pass by adding explicit type information to render props * Move CheckboxGroup flexWrap styling prop to options list from parent container * add flexWrap to storybook args --------- Co-authored-by: Tyler Krys <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the React component libraries to latest where possible. Of note:
react-aria-componentsmoves to v1.3.3@bcgov/design-tokensmoves to v3.1.0Some new commits related to tests:
Buttonclasses. I started this work while trying to test the specific value of the design tokens being applied, but this is much harder than anticipated with Jest/JSDOM (I could only read the genericButtonFaceCSS rule, not our design token colors). I started down the road of replacing Jest with Vitest because of how slow and wonky Jest is, but I found the existingButtontests wouldn't "just work" in Vitest yet because of differences in theexpect()API between Jest and Vitest. There is a branchtest/vitestwhere I've started down the replacement path, but it's not ready for prime time.ButtonGroup.Formcomponent interface, and I fixed that in 50c5bb0. Right now there are no lint rules failing.