Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch cursor styles apply to label for accessibility affordance #489

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

ty2k
Copy link
Contributor

@ty2k ty2k commented Sep 12, 2024

This moves the cursor CSS rules in the Switch component from child indicator/container elements to the parent element. This has the effect of displaying the interactive pointer cursor when a user hovers on the label of the Switch, which is clickable.

Currently:
https://github.com/user-attachments/assets/f500c93d-c4a9-427a-ac51-5e8ac34cf9e8

After this PR:
https://github.com/user-attachments/assets/9bee5b4b-3e03-482d-8821-b4a475a068a0

@ty2k ty2k added the enhancement New feature or request label Sep 12, 2024
@ty2k ty2k added this to the Components v0.3.0 milestone Sep 12, 2024
@ty2k ty2k requested a review from mkernohanbc September 12, 2024 22:48
@ty2k ty2k self-assigned this Sep 12, 2024
@ty2k ty2k merged commit 64a08ee into main Sep 12, 2024
4 checks passed
@ty2k ty2k deleted the feature/switch-cursor-style branch September 12, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants