Refactor Select to use ListBoxSection #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Holding on merging until #500 is resolved. |
mkernohanbc
added a commit
that referenced
this pull request
Dec 11, 2024
mkernohanbc
added a commit
that referenced
this pull request
Feb 3, 2025
* implement RAC Text * scaffolding Text docs * WIP on implementing BCDS typescale * React Aria library update to 1.5.0 * Add Accordion and AccordionGroup components (#499) * staging Accordion and AccordionGroup file structure * bump RAC to 1.4.0 * basic shape of Accordion component * tweak props import * add story wireframe for Accordion * styling accordion * styling * additional styling and alternative icon implementation * refining button styling * scaffolding AccordionGroup * add title prop and styling to AccordionGroup * continuing work on Accordion and AccordionGroup styling * fix focus state for accordions inside accordiongroup * fleshing out argTypes * scaffolding accordion docs * add examples to vite kitchen sink * fleshing out examples on vite * expanding stories and docs * stories and docs * typo * renaming CSS classes to bcds-react-aria-* to match convention * typo * add comments to accordion group props * remove unused CSS class * bump RAC to 1.5.0 * update RAC imports * Refactor Select to use ListBoxSection (#504) * bump RAC to 1.5.0 * replace Section with ListBoxSection * Revert "bump RAC to 1.5.0" This reverts commit 75e05e7. * Reapply "bump RAC to 1.5.0" This reverts commit 0edc443. * storybook library update to 8.4.7 * add TextProps, refining styling * add missing CSS import * fork Heading styles into new component * add vite page for dev and testing * demo content * add text colour prop * wireframing storybook docs * add isUnstyled prop to Heading and Text * docs and stories * add color prop to Heading and flesh out docs * add ARIA attribute to fix accessibility violation * add explicit default elementType * add missing elementType declaration * docs edits --------- Co-authored-by: Arora <[email protected]> Co-authored-by: Supriya-Arora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #503 with a small change to the Select component, replacing the RAC Section subcomponent (deprecated in 1.5.0) with the ListBoxSection subcomponent. This change is dependent on #500.
Section was only used internally within Select (ie. our users are not importing/working with Section directly), so there should be no downstream impact for users from this change. The component is configured and will render as before.