Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make kwh optional for fse #1753

Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix: make kwh optional for fse #1753

merged 1 commit into from
Jan 21, 2025

Conversation

kevin-hashimoto
Copy link
Collaborator

@kevin-hashimoto kevin-hashimoto marked this pull request as ready for review January 21, 2025 17:10
@github-actions GitHub Actions
Copy link

Frontend Test Results

  1 files  ±0  123 suites  ±0   44s ⏱️ -5s
429 tests ±0  409 ✅ ±0  20 💤 ±0  0 ❌ ±0 
431 runs  ±0  411 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 19b6d67. ± Comparison against base commit 97b1d56.

@github-actions GitHub Actions
Copy link

Backend Test Results

503 tests  ±0   503 ✅ ±0   1m 44s ⏱️ +2s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 19b6d67. ± Comparison against base commit 97b1d56.

dhaselhan
dhaselhan approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@dhaselhan dhaselhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kevin-hashimoto kevin-hashimoto merged commit db7eea4 into release-0.2.0 Jan 21, 2025
1 check passed
@kevin-hashimoto kevin-hashimoto deleted the feat/kevin-1701 branch January 21, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhaselhan dhaselhan dhaselhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LCFS - Make the FSE ID grid column "kWh usage" an optional input rather than a mandatory one
2 participants
@kevin-hashimoto @dhaselhan