Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update met/not met logic #1844

Merged
merged 2 commits into from
Jan 30, 2025
Merged

fix: Update met/not met logic #1844

merged 2 commits into from
Jan 30, 2025
+19 −15

Conversation

dhaselhan
Copy link
Collaborator

  • It should be checking the summary penalty amount not the amounts in the report

@dhaselhan
fix: Update met/not met logic
Loading
Loading status checks…
f37765e 
* It should be checking the summary penalty amount not the amounts in the report
@dhaselhan dhaselhan requested a review from AlexZorkin January 29, 2025 18:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2025 •
edited
Loading

Frontend Test Results

  1 files  ±0  125 suites  ±0   45s ⏱️ ±0s
436 tests ±0  416 ✅ ±0  20 💤 ±0  0 ❌ ±0 
438 runs  ±0  418 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 82de0d8. ± Comparison against base commit 2119481.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2025 •
edited
Loading

Backend Test Results

521 tests  ±0   521 ✅ ±0   1m 50s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 82de0d8. ± Comparison against base commit 2119481.

♻️ This comment has been updated with latest results.

prv-proton
prv-proton approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@prv-proton prv-proton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dhaselhan dhaselhan merged commit d07fe5f into release-0.2.0 Jan 30, 2025
1 check passed
@dhaselhan dhaselhan deleted the fix/daniel-met-notmet-1782 branch January 30, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prv-proton prv-proton

@AlexZorkin AlexZorkin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhaselhan @prv-proton