-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking pull request to merge release-1.0.0 to main #1852
Open
kuanfandevops
wants to merge
24
commits into
main
Choose a base branch
from
release-1.0.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,397
−1,252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frontend Test Results 1 files 125 suites 47s ⏱️ Results for commit 077d570. ♻️ This comment has been updated with latest results. |
Backend Test Results524 tests 524 ✅ 1m 51s ⏱️ Results for commit 077d570. ♻️ This comment has been updated with latest results. |
* Fuel code was using custom logic meaning it didnt get any of the yellow upgrades done previously * Remove the FE logic to Backend validation and let the errors go through the normal validation route
* Method currently checks whichever ID was passed in, always check the from_organization_id for the balance. * Remove txn:description text as per business request
* Previously a supplier would be blocked if they didnt have enough credits * Now we take as many as we can and allow it
…1861 fix: Check from organization balance
…-1848 fix: Allow Submissions without enough credits
…-1809 Fix: LCFS - backend filter logic on the Compliance Report index #1809
Fix: Updated Materialized Views, Functions, Triggers - 1813
fix: Move Fuel Code validation to the back end
* It should be checking the summary penalty amount not the amounts in the report
fix: Update met/not met logic
Feat: Add Historical Rejected Status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.