Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Not Recommended status #2136

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
"""Add not recommended

Revision ID: d21997277eca
Revises: 985de92bdf83
Create Date: 2025-02-28 18:38:10.952016

"""

from alembic import op

# revision identifiers, used by Alembic.
revision = "d21997277eca"
down_revision = "985de92bdf83"
branch_labels = None
depends_on = None


def upgrade() -> None:
# ### commands auto generated by Alembic - please adjust! ###
op.execute(
"ALTER TYPE compliancereportstatusenum ADD VALUE 'Not_recommended_by_analyst';"
)
op.execute(
"ALTER TYPE compliancereportstatusenum ADD VALUE 'Not_recommended_by_manager';"
)

# Commit enum so it can be used below
op.execute("COMMIT")

op.execute(
"""
INSERT INTO "public"."compliance_report_status"("compliance_report_status_id", "status", "effective_status") VALUES(8, 'Not_recommended_by_analyst', 't');
"""
)

op.execute(
"""
INSERT INTO "public"."compliance_report_status"("compliance_report_status_id", "status", "effective_status") VALUES(9, 'Not_recommended_by_manager', 't');
"""
)


def downgrade() -> None:
pass
2 changes: 2 additions & 0 deletions backend/lcfs/db/models/compliance/ComplianceReportStatus.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ class ComplianceReportStatusEnum(enum.Enum):
Submitted = "Submitted"
Recommended_by_analyst = "Recommended by analyst"
Recommended_by_manager = "Recommended by manager"
Not_recommended_by_analyst = "Not recommended by analyst"
Not_recommended_by_manager = "Not recommended by manager"
Assessed = "Assessed"
Reassessed = "Reassessed"
Rejected = "Rejected"
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/assets/locales/en/reports.json
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,9 @@
"Submitted": "Signed and submitted {{createDate}} by {{displayName}}.",
"Recommended by analyst": "Recommended {{createDate}} by {{displayName}}.",
"Recommended by manager": "Recommended {{createDate}} by {{displayName}}.",
"Not recommended by analyst": "Not recommended {{createDate}} by {{displayName}}.",
"Not recommended by manager": "Not recommended {{createDate}} by {{displayName}}.",
"Rejected": "Rejected {{createDate}} by {{displayName}}.",
"Assessed": "Assessed {{createDate}} by {{displayName}}.",
"AssessedBy": "Assessed {{createDate}} by the director under the <i>Low Carbon Fuels Act.</i>",
"Reassessed": "Re-assessed"
Expand Down