Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #619 iMapBC public link #621

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Conversation

ianliuwk1019
Copy link
Collaborator

@ianliuwk1019 ianliuwk1019 commented Apr 26, 2024

ref: #619

  • update the text on the about page for the iMpasBC button
    '''
    View and analyze hundreds of map data layers compiled from across the B.C. Government, and other public sector agencies. This includes the FOM layers, which can be overlayed onto other layers, allowing the user to see FOM features from all published FOMs on one comprehensive map.
    '''
  • add ghost-button that launches iMapsBC in a new tab (https://maps.gov.bc.ca/ess/hm/imap4m/) at public map details.

Thanks for the PR!

Any successful deployments (not always required) will be available below.

Once merged, code will be promoted and handed off to following workflow run.


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Once merged, code will be promoted and handed off to following workflow run.

@ianliuwk1019 ianliuwk1019 marked this pull request as ready for review April 27, 2024 03:25
@MCatherine1994
Copy link
Contributor

Looks good to me, maybe just let Olga review the UI styling, thanks Ian!!

@ianliuwk1019
Copy link
Collaborator Author

Thanks for the quick review @MCatherine1994 !!
Hi @OlgaLiber2 , there is nothing change for the elements spacing this time, only the iMapBC link is added on top of the Map Details.
Since it looks ok and Julius would like this in this morning, I would just merge this isolated change this time so it will be available for him soon. We can collect other UI adjustments in other ticket together if there are others.
Thanks Olga.

@OlgaLiber2
Copy link
Collaborator

OlgaLiber2 commented Apr 29, 2024

@ianliuwk1019 sure, can you capture that UI change in a new ticket please? We can add other styling changes to that ticket as well in the future. Thanks for deploying it so promptly. I appreciate it.

Thanks OIga. Ticket #622 created.

@ianliuwk1019 ianliuwk1019 merged commit 9645c1b into main Apr 29, 2024
18 checks passed
@ianliuwk1019 ianliuwk1019 deleted the feat/619-imapsbc-public-link branch April 29, 2024 16:51
@webgismd
Copy link
Contributor

webgismd commented May 1, 2024

For iMapBC you can add parameters to the url to add the FOM layers on startup.. I can provide the syntax if people want it.

@OlgaLiber2
Copy link
Collaborator

@webgismd yes please. Thank you!
@ianliuwk1019 we can create a new ticket to open FOM layers on startup

@ianliuwk1019
Copy link
Collaborator Author

We had quick exploring on the iMapBC and its site help but didn't discover the parameters we had thought. If there is a reference doc for how to, that would be great. Thank you very much @webgismd .

@webgismd
Copy link
Contributor

webgismd commented May 1, 2024

here is an example of the FOM layers added on startup https://maps.gov.bc.ca/ess/hm/imap4m/?catalogLayers=9448,9449,9450,9451,9452,9453 -- there are other parameters we could explore with DataBC... it uses Geocortex Essentials https://docs.vertigisstudio.com/essentials/gvh/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants