feat: 1353 add lint to workflows (#1592)

Co-authored-by: Ricardo Campos <[email protected]>
bcgov · Sep 3, 2024 · 6e5f518 · 6e5f518
1 parent d2b2d30
commit 6e5f518
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 9 deletions.
diff --git a/.github/workflows/analysis.yml b/.github/workflows/analysis.yml
@@ -14,6 +14,18 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  lint:
+    name: Typescript lint
+    runs-on: ubuntu-22.04
+    steps:
+      - uses: bcgov-nr/[email protected]
+        with:
+          commands: |
+            npm ci
+            npm run lint
+          dir: frontend
+          node_version: "20"
+
   tests:
     name: Java CI
     if: ${{ ! github.event.pull_request.draft }}
@@ -65,7 +77,7 @@ jobs:
   results:
     name: Analysis Results
     if: always() && (!failure()) && (!cancelled())
-    needs: [tests, trivy]
+    needs: [lint, tests, trivy]
     runs-on: ubuntu-22.04
     steps:
       - run: echo "Workflow completed successfully!"
diff --git a/frontend/src/components/BCHeader/constants.ts b/frontend/src/components/BCHeader/constants.ts
@@ -101,13 +101,13 @@ export const navItems = [
 export const supportItems = {
   name: 'Support',
   items: [
-// Uncomment these as necessary :)
-//     {
-//       name: 'Need help?',
-//       icon: 'Help',
-//       link: '#',
-//       disabled: true
-//     },
+  // Uncomment these as necessary :)
+  //     {
+  //       name: 'Need help?',
+  //       icon: 'Help',
+  //       link: '#',
+  //       disabled: true
+  //     },
     {
       name: 'Service status',
       icon: 'CloudMonitoring',

diff --git a/frontend/src/components/BCHeader/index.tsx b/frontend/src/components/BCHeader/index.tsx
@@ -206,7 +206,11 @@ const BCHeader = () => {
                   <SideNavLink
                     key={supportItem.name}
                     renderIcon={Icons[supportItem.icon]}
-                    className={supportItem.disabled ? 'disabled-side-nav-option' : 'side-nav-option'}
+                    className={
+                    supportItem.disabled
+                      ? 'disabled-side-nav-option'
+                      : 'side-nav-option'
+                    }
                     onClick={supportItem.disabled ? null : () => navigate(supportItem.link)}
                   >
                     {supportItem.name}