Skip to content

Commit

Permalink
feat: changing field texts (#1347)
Browse files Browse the repository at this point in the history
  • Loading branch information
mgaseta authored Jul 8, 2024
1 parent 8257d0a commit bef590d
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 9 deletions.
2 changes: 1 addition & 1 deletion frontend/cypress/fixtures/dashboard-page.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"subtitle": "See your favourite and recent activities inside SPAR system",
"subtitle": "",
"emptySectionTitle": "You don't have any favourites to show yet!",
"emptySectionSubtitle": "You can favourite your most used activities by clicking on the heart icon inside each page"
}
2 changes: 1 addition & 1 deletion frontend/src/__test__/components/RecentActivities.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ describe('Recent Activities component', () => {
await waitFor(() => {
const tabs = screen.getAllByRole('tab');
expect(tabs[0].textContent).toEqual('Requests');
expect(tabs[1].textContent).toEqual('Files & Docs.');
expect(tabs[1].textContent).toEqual('Files & Docs');

// Setting this small timeout so the component ends rendering
// the loading status and render the content we want to test
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/LotApplicantAndInfoForm/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ const LotApplicantAndInfoForm = ({
name="email"
type="email"
labelText="Applicant email address"
helperText="The Tree Seed Centre will uses it to communicate with the applicant"
helperText="The Tree Seed Centre will use this to communicate with the applicant"
invalid={seedlotFormData ? seedlotFormData.email.isInvalid : null}
invalidText="Please enter a valid email"
onBlur={(e: React.ChangeEvent<HTMLInputElement>) => handleEmail(e.target.value)}
Expand Down
3 changes: 1 addition & 2 deletions frontend/src/components/RecentActivities/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,10 @@ export const filesAndDocsHeaders: string[] = [

export const componentTexts = {
title: 'My recent activities',
subtitle: 'Check your recent requests and files',
tabs: {
ariaLabel: 'List of tabs',
requests: 'Requests',
files: 'Files & Docs.'
files: 'Files & Docs'
}
};

Expand Down
2 changes: 0 additions & 2 deletions frontend/src/components/RecentActivities/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import {
} from '@carbon/react';

import EmptySection from '../EmptySection';
import Subtitle from '../Subtitle';
import RecentActivitiesTable from './RecentActivitiesTable';

import {
Expand Down Expand Up @@ -49,7 +48,6 @@ const RecentActivities = () => {
<Row className="recent-activity-title-row">
<Column>
<h2>{componentTexts.title}</h2>
<Subtitle text={componentTexts.subtitle} className="recent-activity-subtitle" />
</Column>
</Row>
<Row>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const CollectionReviewRead = () => {
<Column className="info-col" sm={4} md={4} lg={4}>
<ReadOnlyInput
id="applicant-and-seedlot-agency-loc-code"
label="Cone collector agency number"
label="Cone collector location code"
value={allStepData.collectionStep.locationCode.value}
showSkeleton={isFetchingData}
/>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/views/Dashboard/dashboard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const Dashboard = () => (
<Column>
<PageTitle
title="Dashboard"
subtitle="See your favourite and recent activities inside SPAR system"
subtitle=""
/>
</Column>
</Row>
Expand Down

0 comments on commit bef590d

Please sign in to comment.