Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): set environment at top level #1482

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Aug 7, 2024

Description

Sync has not been getting updated property in the TEST workflow. That was due to environments being inconsistently set. This PR applies environments at the workflow/top level, making these mistakes harder to repeat.

Changelog

Changed

  • Environment handling in .deploy.yml

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@DerekRoberts DerekRoberts self-assigned this Aug 7, 2024
@DerekRoberts DerekRoberts added bug Something isn't working devops devops related task labels Aug 7, 2024
@DerekRoberts DerekRoberts marked this pull request as ready for review August 7, 2024 02:09
Copy link
Contributor

@ronrobb ronrobb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AHA!

@DerekRoberts DerekRoberts merged commit 6743925 into main Aug 7, 2024
21 checks passed
@DerekRoberts DerekRoberts deleted the fix/ci/staleSyncImages branch August 7, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devops devops related task
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants