-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: modal to add favourite activity #1794
Conversation
@SLDonnelly @xiaopeng0202 |
are you able to access https://nr-spar-44-frontend.apps.silver.devops.gov.bc.ca/consep/favourite-activities ? |
Sorry, thought I left a comment already - Also, @SLDonnelly , I'm thinking we might want to rename the "Withdrawal" category to be "Inventory management" - what do you think? |
backend/src/main/java/ca/bc/gov/backendstartapi/service/FavouriteActivityService.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ca/bc/gov/backendstartapi/service/FavouriteActivityService.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/ca/bc/gov/backendstartapi/service/FavouriteActivityServiceTest.java
Show resolved
Hide resolved
frontend/src/components/Card/FavouriteCard/FavouriteConsepCard.tsx
Outdated
Show resolved
Hide resolved
…637-add-favourite-modal
Sorry, I was investigating the blue line issue, but did not find the root cause. Maybe I can create a ticket for further investigation in an upcoming PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Closes #1637
Changelog
New
How was this tested?
What gif/image best describes this PR or how it makes you feel?
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: