Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modal to add favourite activity #1794

Merged
merged 31 commits into from
Jan 21, 2025
Merged

Conversation

xiaopeng0202
Copy link
Collaborator

@xiaopeng0202 xiaopeng0202 commented Dec 20, 2024

Description

Closes #1637

Changelog

New

  • new modal to list all the consep activities
  • can select/unselect activities in the modal
  • refactor backend api to support handle mutiple activities

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@xiaopeng0202 xiaopeng0202 marked this pull request as ready for review January 7, 2025 22:24
@kevinginley
Copy link
Collaborator

@SLDonnelly @xiaopeng0202
With my "Ministry of Forests" SPAR account, I do not yet have access to the "Tree Seed Centre" link in the navigation, so I don't think I can make my way to the "add favourite activity" modal to test on the front-end.

@xiaopeng0202
Copy link
Collaborator Author

@SLDonnelly @xiaopeng0202 With my "Ministry of Forests" SPAR account, I do not yet have access to the "Tree Seed Centre" link in the navigation, so I don't think I can make my way to the "add favourite activity" modal to test on the front-end.

are you able to access https://nr-spar-44-frontend.apps.silver.devops.gov.bc.ca/consep/favourite-activities ?

@kevinginley
Copy link
Collaborator

Sorry, thought I left a comment already -
I can access the modal through that link, thank you. It's looking good! One minor thing: a blue line appears briefly around most of the modal whenever I click on a checkbox (screenshot below) Can we get it to not do that, if it's not too much trouble?

Screenshot (414)

Also, @SLDonnelly , I'm thinking we might want to rename the "Withdrawal" category to be "Inventory management" - what do you think?

Base automatically changed from feat/1580-list-favorite-activity-in-consep to main January 14, 2025 17:11
@xiaopeng0202
Copy link
Collaborator Author

Sorry, thought I left a comment already - I can access the modal through that link, thank you. It's looking good! One minor thing: a blue line appears briefly around most of the modal whenever I click on a checkbox (screenshot below) Can we get it to not do that, if it's not too much trouble?

Screenshot (414)

Also, @SLDonnelly , I'm thinking we might want to rename the "Withdrawal" category to be "Inventory management" - what do you think?

Sorry, I was investigating the blue line issue, but did not find the root cause. Maybe I can create a ticket for further investigation in an upcoming PR.

Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xiaopeng0202 xiaopeng0202 merged commit 4bc965b into main Jan 21, 2025
28 of 29 checks passed
@xiaopeng0202 xiaopeng0202 deleted the feat/1637-add-favourite-modal branch January 21, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screen list /modal for "add favourite" feature
3 participants