Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/453 step 4 validation fe #699

Merged
merged 11 commits into from
Dec 12, 2023
Merged

Feat/453 step 4 validation fe #699

merged 11 commits into from
Dec 12, 2023

Conversation

craigyu
Copy link
Collaborator

@craigyu craigyu commented Dec 5, 2023 •
edited by github-actions bot
Loading

Description

Closes #453

Changelog

Changed

  • Refactored input types on Orchard step, didn't change the type for boolean fields as it appears to be useless to use it here.
  • Changed Male Gametic option selection to combobox after discussing with Sabina, Michelly and Andrea.
  • Updated some input labels according to the new design
  • Fixed a bug where if a parent tree contains an orchard ID that is not present in the Orchard-Spu table, then the endpoint will crash. This will probably only happen in the test environment, but as a precautionary act I have added a guard that checks if the orchard id is present in the orchard-spu table.
    • MicrosoftTeams-image (9)
    • Here orchard id 001 does not exist for species FDI
    • You can reproduce an error on our current test environment by having an FDI seedlot, then try to fetch parent trees by species in step 5, a 500 error will be thrown
  • Optimized the updateProgressStatus function by adding a prevStepNum param, we will only check the validity and completeness of a step if the user just click out of the that step. This prevents every step getting checked when a user changes step.

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@craigyu craigyu added the full-stack full-stack related task label Dec 5, 2023
@craigyu craigyu self-assigned this Dec 5, 2023
@craigyu craigyu linked an issue Dec 5, 2023 that may be closed by this pull request
Step 4 Validation [FE] #453
Closed
2 tasks
mgaseta
mgaseta requested changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, added only a few comments.

frontend/src/components/SeedlotRegistrationSteps/OrchardStep/index.tsx Outdated Show resolved Hide resolved
frontend/src/components/SeedlotRegistrationSteps/OrchardStep/definitions.ts Outdated Show resolved Hide resolved
frontend/src/components/SeedlotRegistrationSteps/OrchardStep/index.tsx Show resolved Hide resolved
@craigyu
Merge commit '028569e4f6902711c251178e9a06103d3b5125dc' into feat/453…
6420e9b 
…-step-4-validation-fe

# Conflicts:
#	frontend/src/views/Seedlot/SeedlotRegistrationForm/index.tsx
@craigyu
Merge branch 'feat/453-step-4-validation-fe' of https://github.com/bc…
a1ba34d 
…gov/nr-spar into feat/453-step-4-validation-fe
@craigyu
fix: ids and boolean input types
bf3138c
@craigyu craigyu requested a review from mgaseta December 12, 2023 19:09
mgaseta
mgaseta approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@craigyu craigyu merged commit 53c251c into main Dec 12, 2023
15 of 16 checks passed
@craigyu craigyu deleted the feat/453-step-4-validation-fe branch December 12, 2023 21:42
DerekRoberts pushed a commit that referenced this pull request May 13, 2024
@craigyu @DerekRoberts
Feat/453 step 4 validation fe (#699)
abeda4e 
* feat: refactor types

* feat: orchard step validation

* fix: form review

* fix: ids and boolean input types

* fix: form review tempalte
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
@craigyu @DerekRoberts
Feat/453 step 4 validation fe (#699)
f8efd21 
* feat: refactor types

* feat: orchard step validation

* fix: form review

* fix: ids and boolean input types

* fix: form review tempalte
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
@craigyu @DerekRoberts
Feat/453 step 4 validation fe (#699)
c838921 
* feat: refactor types

* feat: orchard step validation

* fix: form review

* fix: ids and boolean input types

* fix: form review tempalte
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
@craigyu @DerekRoberts
Feat/453 step 4 validation fe (#699)
6c241fd 
* feat: refactor types

* feat: orchard step validation

* fix: form review

* fix: ids and boolean input types

* fix: form review tempalte
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgaseta mgaseta mgaseta approved these changes

@RMCampos RMCampos Awaiting requested review from RMCampos

@DerekRoberts DerekRoberts Awaiting requested review from DerekRoberts DerekRoberts is a code owner

@SLDonnelly SLDonnelly Awaiting requested review from SLDonnelly SLDonnelly is a code owner

Assignees

@craigyu craigyu

Labels
full-stack full-stack related task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Step 4 Validation [FE]
2 participants
@craigyu @mgaseta