Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed static home page from onroute main repo #1770

Merged
merged 4 commits into from
Jan 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion frontend/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
ARG VITE_KEYCLOAK_AUDIENCE
ARG VITE_SITEMINDER_LOG_OFF_URL

ENV VITE_DEPLOY_ENVIRONMENT $VITE_DEPLOY_ENVIRONMENT

Check warning on line 15 in frontend/Dockerfile

View workflow job for this annotation

GitHub Actions / Builds (frontend)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV VITE_API_VEHICLE_URL $VITE_API_VEHICLE_URL

Check warning on line 16 in frontend/Dockerfile

View workflow job for this annotation

GitHub Actions / Builds (frontend)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV VITE_POLICY_URL $VITE_POLICY_URL

Check warning on line 17 in frontend/Dockerfile

View workflow job for this annotation

GitHub Actions / Builds (frontend)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV VITE_KEYCLOAK_ISSUER_URL $VITE_KEYCLOAK_ISSUER_URL

Check warning on line 18 in frontend/Dockerfile

View workflow job for this annotation

GitHub Actions / Builds (frontend)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV VITE_KEYCLOAK_AUDIENCE $VITE_KEYCLOAK_AUDIENCE

Check warning on line 19 in frontend/Dockerfile

View workflow job for this annotation

GitHub Actions / Builds (frontend)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV VITE_SITEMINDER_LOG_OFF_URL $VITE_SITEMINDER_LOG_OFF_URL

Check warning on line 20 in frontend/Dockerfile

View workflow job for this annotation

GitHub Actions / Builds (frontend)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

# Install app dependencies
COPY ./package*.json ./
Expand All @@ -41,11 +41,10 @@
EXPOSE 3000

# Have only the compiled app, ready for production with Nginx
FROM nginx:1.27-alpine as production-stage

Check warning on line 44 in frontend/Dockerfile

View workflow job for this annotation

GitHub Actions / Builds (frontend)

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
RUN mkdir /app
COPY --from=builder /app/build /usr/share/nginx/html
COPY nginx.conf /etc/nginx/nginx.conf
COPY static_home_page /usr/share/nginx/html
CMD ["nginx", "-g", "daemon off;"]

RUN apk add --no-cache curl
Expand Down
6 changes: 0 additions & 6 deletions frontend/nginx.conf
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,6 @@ http {
try_files $uri $uri/ /index.html;
}

location /home {
root /usr/share/nginx/html;
index home.html;
try_files $uri $uri/ /home.html;
}

error_page 500 502 503 504 /50x.html;

# To allow POST on static pages
Expand Down
5 changes: 0 additions & 5 deletions frontend/static_home_page/README.md

This file was deleted.

52 changes: 0 additions & 52 deletions frontend/static_home_page/css/reset.css

This file was deleted.

Loading
Loading