Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove JS handling from workflow conditionals #1776

Merged
merged 1 commit into from
Jan 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
# https://github.com/github/codeql-action
codeql:
name: CodeQL
if: ${{ ! github.event.pull_request.draft }}
if: (! github.event.pull_request.draft)
runs-on: ubuntu-22.04
timeout-minutes: 5
steps:
Expand All @@ -38,7 +38,7 @@ jobs:
# https://github.com/marketplace/actions/aqua-security-trivy
trivy:
name: Trivy Security Scan
if: ${{ ! github.event.pull_request.draft }}
if: (! github.event.pull_request.draft)
runs-on: ubuntu-22.04
timeout-minutes: 1
steps:
Expand All @@ -60,7 +60,7 @@ jobs:

tests:
name: Tests
if: ${{ ! github.event.pull_request.draft }}
if: (! github.event.pull_request.draft)
runs-on: ubuntu-22.04
timeout-minutes: 5
services:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,12 +149,12 @@ jobs:
echo "No triggers have fired, deployment skipped"

- uses: redhat-actions/openshift-tools-installer@v1
if: ${{ steps.triggers.outputs.triggered == 'true' }}
if: steps.triggers.outputs.triggered == 'true'
with:
oc: "4"

- name: Deploy if Triggers Fired
if: ${{ steps.triggers.outputs.triggered == 'true' }}
if: steps.triggers.outputs.triggered == 'true'
working-directory: ${{ inputs.directory }}
shell: bash
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
steps:
# Get PR number for squash merges to main
- name: Get PR Number From Event
if: ${{ github.event_name == 'push' }}
if: github.event_name == 'push'
id: pr_no
uses: bcgov/[email protected]
- name: PR Number
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/notifications.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
- completed
jobs:
notify-teams-pr:
if: ${{github.event.workflow_run.event == 'pull_request'}}
if: github.event.workflow_run.event == 'pull_request'
runs-on: ubuntu-22.04
steps:
- uses: simbo/msteams-message-card-action@latest
Expand All @@ -26,7 +26,7 @@ jobs:
image: ${{github.event.workflow_run.head_repository.owner.avatar_url}}
text: PR Opened
notify-teams-merged:
if: ${{github.event.workflow_run.event == 'push'}}
if: github.event.workflow_run.event == 'push'
runs-on: ubuntu-22.04
steps:
- name: PR Number
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
steps:
# Get PR number for squash merges to main
- name: Get PR Number From Event
if: ${{ github.event_name == 'release' }}
if: github.event_name == 'release'
id: pr_no
uses: bcgov/action-get-pr@main
- name: PR Number
Expand Down
Loading