Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORV2-2848 - FE: Staff Edit Application in the Queue #1805

Merged
merged 22 commits into from
Feb 13, 2025
Merged

ORV2-2848 - FE: Staff Edit Application in the Queue #1805

merged 22 commits into from
Feb 13, 2025

Conversation

glen-aot
Copy link
Collaborator

@glen-aot glen-aot commented Feb 10, 2025 •
edited by github-actions bot
Loading

Description

Implements functionality for staff to edit applications in queue (currently only STOS)

Fixes #ORV2-2848

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

glen-aot and others added 18 commits December 17, 2024 09:49
@glen-aot
remove need for ReviewApplicationInQueue and ApplicationInQueueReview…
85a1e57 
… components
@glen-aot
Merge remote-tracking branch 'origin/main'
684a4cf
@praju-aot
Pass claimant back to the FE
7c0a0b3
@glen-aot
create UnavailableApplicationModal
039cb6e
@glen-aot
restore ApplicationInQueueReview component
90ff834
@glen-aot
explore claimed application error state
d0dd37b
@glen-aot @praju-aot
remove example for calling BE in ApplicationForm.tsx
9454016
@praju-aot
Merge remote-tracking branch 'origin/main' into ORV2-2848
1280cae
@glen-aot
add check for currentUser against application claimedBy in Applicatio…
9bcab3a 
…nReview and ApplicationForm in queue context
@glen-aot
change currentClaimant variable name to assignedUser to match backend
2ecf96d
@glen-aot
add logic for checking current assignedUser to ApplicationsInQueueList
4f2623e
@glen-aot
Merge remote-tracking branch 'origin/main' into ORV2-2848
718b3fd
@glen-aot
prevent users from accidentally claiming an application fromn the app…
fc4849d 
…lications in queue screen when it has already been claimed
@glen-aot
update ApplicationReview test to render component with updated props
be810be
@glen-aot
update ApplicationsInQueueList to fix issue with claiming a claimed a…
a03af7a 
…pplication behaviour
@glen-aot
prevent users from saving changes to an application when hitting Cont…
f865b78 
…inue or Save buttons if that application has been stolen
@glen-aot
update ApplicationReview to handle Approve and Reject when an applica…
cca6d1a 
…tion has been stolen by another user
@glen-aot
Merge remote-tracking branch 'origin/main' into ORV2-2848
e96aefa
@glen-aot
remove need for applicationData and companyIdProp in ApplicationRevie…
c74dca0 
…w component. Add check for IDIR user in useApplionMetadata hook to prevent request from being made as BCeID user
@glen-aot
Merge remote-tracking branch 'origin' into ORV2-2848
c64cccd
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'onroutebc_policy'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'onroutebc dops'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'onroutebc_scheduler'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'onroutebc vehicles'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'onroutebc frontend'

Failed conditions
40.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@glen-aot glen-aot merged commit 14f1607 into main Feb 13, 2025
23 of 24 checks passed
@glen-aot glen-aot deleted the ORV2-2848 branch February 13, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zgong-gov zgong-gov zgong-gov approved these changes

@gchauhan-aot gchauhan-aot Awaiting requested review from gchauhan-aot gchauhan-aot is a code owner

@praju-aot praju-aot Awaiting requested review from praju-aot praju-aot is a code owner

@krishnan-aot krishnan-aot Awaiting requested review from krishnan-aot krishnan-aot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glen-aot @zgong-gov @praju-aot