Fix to show correct error when all home owners deleted (#1957)

bcgov · Jun 28, 2024 · 3f4ea99 · 3f4ea99
1 parent ba02924
commit 3f4ea99
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/ppr-ui/package-lock.json b/ppr-ui/package-lock.json
diff --git a/ppr-ui/package.json b/ppr-ui/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ppr-ui",
-  "version": "3.2.28",
+  "version": "3.2.29",
   "private": true,
   "appName": "Assets UI",
   "sbcName": "SBC Common Components",

diff --git a/ppr-ui/src/components/mhrRegistration/HomeOwners/HomeOwnersTable.vue b/ppr-ui/src/components/mhrRegistration/HomeOwners/HomeOwnersTable.vue
@@ -970,6 +970,14 @@ export default defineComponent({
         item.groupId
       )
 
+      const group: MhrRegistrationHomeOwnerGroupIF = getGroupById(item.groupId)
+      const isEmptyGroup = group.owners.every(owner => owner.action === ActionTypes.REMOVED)
+
+      // mark empty groups as removed to show the 'No owners added yet' error
+      if (isEmptyGroup) {
+        group.action = ActionTypes.REMOVED
+      }
+
       // When base ownership is SO/JT and all current owners have been removed: Move them to a previous owners group.
       if (groupHasRemovedAllCurrentOwners(getGroupById(item.groupId)) && showGroups.value) {
         moveCurrentOwnersToPreviousOwners(getGroupById(item.groupId))

diff --git a/ppr-ui/tests/unit/MhrTransferHomeOwners.spec.ts b/ppr-ui/tests/unit/MhrTransferHomeOwners.spec.ts
@@ -418,7 +418,7 @@ describe('Home Owners', () => {
     expect(allDeletedBadges.length).toBe(1)
 
     expect(homeOwners.find(getTestId('invalid-group-msg')).exists()).toBeFalsy()
-    expect(homeOwners.find(getTestId('no-data-msg')).exists()).toBeFalsy()
+    expect(homeOwners.find(getTestId('no-data-msg')).exists()).toBeTruthy()
 
     const deletedOwner: MhrRegistrationHomeOwnerIF =
       homeOwners.vm.getMhrTransferHomeOwnerGroups[0].owners[0]