Skip to content

Commit

Permalink
fixed error on person giving note (#1980)
Browse files Browse the repository at this point in the history
* fixed error on person giving note

* changed version number

* addressed comments
  • Loading branch information
flutistar authored Jul 16, 2024
1 parent 8a9eb55 commit 6f916ef
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions ppr-ui/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ppr-ui/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ppr-ui",
"version": "3.2.38",
"version": "3.2.39",
"private": true,
"appName": "Assets UI",
"sbcName": "SBC Common Components",
Expand Down
2 changes: 1 addition & 1 deletion ppr-ui/src/components/unitNotes/UnitNoteReview.vue
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ export default defineComponent({
const localState = reactive({
validateSubmittingParty: false,
initialAttention: getMhrUnitNoteRegistration.value?.attentionReference,
initialAttention: isCancelUnitNote.value ? '' : getMhrUnitNoteRegistration.value?.attentionReference,
unitNoteType: UnitNotesInfo[getMhrUnitNote.value.documentType],
givingNoticeParty: computed((): PartyIF => getMhrUnitNote.value.givingNoticeParty),
unitNoteSubmittingParty: computed(() => getMhrUnitNoteRegistration.value.submittingParty || {}),
Expand Down
1 change: 1 addition & 0 deletions ppr-ui/src/composables/mhrInformation/useMhrUnitNote.ts
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ export const useMhrUnitNote = () => {
cancelUniNote.documentType = UnitNoteDocTypes.NOTE_CANCELLATION
cancelUniNote.documentId = ''
cancelUniNote.destroyed = false
cancelUniNote.hasNoPersonGivingNotice = !note.givingNoticeParty

setMhrUnitNoteRegistration({ key: 'cancelDocumentId', value: note.documentId })
setMhrUnitNoteRegistration({ key: 'submittingParty', value: null })
Expand Down

0 comments on commit 6f916ef

Please sign in to comment.