Misc UXA for Exemptions

bcgov · Apr 23, 2024 · c0b1c06 · c0b1c06
1 parent 049c630
commit c0b1c06
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 15 deletions.
diff --git a/ppr-ui/src/assets/svgs/ic_exemption2.svg b/ppr-ui/src/assets/svgs/ic_exemption2.svg
diff --git a/ppr-ui/src/components/tables/common/TableRow.vue b/ppr-ui/src/components/tables/common/TableRow.vue
@@ -502,7 +502,7 @@
                   <img
                     alt="exemption-icon"
                     class="ml-0 icon-small"
-                    src="@/assets/svgs/ic_exemption.svg"
+                    src="@/assets/svgs/ic_exemption2.svg"
                   >
                   <span class="ml-1">Re-Register Home</span>
                 </v-list-item-subtitle>
@@ -531,7 +531,7 @@
                         <img
                           alt="exemption-icon"
                           class="ml-0 icon-small"
-                          src="@/assets/svgs/ic_exemption.svg"
+                          src="@/assets/svgs/ic_exemption2.svg"
                         >
                         Residential Exemption
                       </span>
@@ -546,7 +546,7 @@
                     <img
                       alt="exemption-icon"
                       class="ml-0 icon-small"
-                      src="@/assets/svgs/ic_exemption.svg"
+                      src="@/assets/svgs/ic_exemption2.svg"
                     >
                     <span class="ml-1">Residential Exemption</span>
                   </span>

diff --git a/ppr-ui/src/composables/exemption/useExemptions.ts b/ppr-ui/src/composables/exemption/useExemptions.ts
@@ -171,7 +171,7 @@ export const useExemptions = () => {
       reg =>
         [APIMhrDescriptionTypes.RESIDENTIAL_EXEMPTION.toString(),
           APIMhrDescriptionTypes.NON_RESIDENTIAL_EXEMPTION.toString()].includes(reg.registrationDescription) &&
-        (reg.statusType === MhApiStatusTypes.EXEMPT || reg.statusType === MhApiStatusTypes.ACTIVE)
+        [MhApiStatusTypes.EXEMPT, MhApiStatusTypes.ACTIVE, MhApiStatusTypes.FROZEN].includes(reg.statusType)
     ).length > 0
   }
 

diff --git a/ppr-ui/src/utils/feature-flags.ts b/ppr-ui/src/utils/feature-flags.ts
@@ -10,14 +10,14 @@ export const defaultFlagSet: LDFlagSet = {
   'search-registration-number': true,
   'search-serial-number': true,
   'mhr-ui-enabled': true, // Mhr Search - default true: Should remove from codebase
-  'mhr-registration-enabled': true, // Enables MHR table tab
-  'mhr-staff-correction-enabled': true, // Enables access to staff mhr correction
-  'mhr-transfer-enabled': true, // Enables changes to base MHR HomeOwners within the MHR Information flow
-  'mhr-exemption-enabled': true,
-  'mhr-non-res-exemption-enabled': true, // Enables Non-Residential Exemption for Staff
-  'mhr-transport-permit-enabled': true,
-  'mhr-amend-transport-permit-enabled': true,
-  'mhr-user-access-enabled': true,
+  'mhr-registration-enabled': false, // Enables MHR table tab
+  'mhr-staff-correction-enabled': false, // Enables access to staff mhr correction
+  'mhr-transfer-enabled': false, // Enables changes to base MHR HomeOwners within the MHR Information flow
+  'mhr-exemption-enabled': false,
+  'mhr-non-res-exemption-enabled': false, // Enables Non-Residential Exemption for Staff
+  'mhr-transport-permit-enabled': false,
+  'mhr-amend-transport-permit-enabled': false,
+  'mhr-user-access-enabled': false,
   'sentry-enable': false, // by default, no sentry logs
   'banner-text': '' // by default, there is no banner text
 }

diff --git a/ppr-ui/src/views/exemption/ExemptionReview.vue b/ppr-ui/src/views/exemption/ExemptionReview.vue
@@ -39,7 +39,7 @@
           <img
             alt="exemption-icon"
             class="ml-0 icon-large"
-            src="@/assets/svgs/ic_exemption.svg"
+            src="@/assets/svgs/ic_exemption2.svg"
           >
           <label class="font-weight-bold pl-2">{{ exemptionLabel }}</label>
         </header>
@@ -247,8 +247,7 @@ export default defineComponent({
     const localState = reactive({
       nonResidentialDisplayReason: computed((): string => {
         const reason = getMhrExemptionNote.value?.nonResidentialReason === 'Other'
-          ? `${getMhrExemptionNote.value?.nonResidentialReason} '${getMhrExemptionNote.value?.nonResidentialOther ||
-          '(Not Entered)'}'`
+          ? `${getMhrExemptionNote.value?.nonResidentialOther || '(Not Entered)'}`
           : getMhrExemptionNote.value?.nonResidentialReason
         return`Reason for the Non-Residential Exemption: ${getMhrExemptionNote.value?.nonResidentialOption} - ${reason}`
       }),