Merge branch 'main' into 22482-fix-error-on-cancel-note

ppr-ui/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ppr-ui",
-  "version": "3.2.44",
+  "version": "3.2.45",
   "private": true,
   "appName": "Assets UI",
   "sbcName": "SBC Common Components",

ppr-ui/src/components/mhrTransfers/DeathCertificate.vue

@@ -137,7 +137,7 @@ export default defineComponent({
       deathCertificateNumberRules: computed((): Array<()=>string|boolean> => {
         return customRules(
           maxLength(20),
-          required('Enter Death Certificate Registration Number')
+          required('Enter death certificate registration number')
         )
       })
     })

ppr-ui/src/components/tables/RegistrationTable.vue

@@ -191,8 +191,8 @@
                     singleLine
                     persistentClear
                     :clearIcon="'mdi-close'"
-                    @click="showDatePicker = true"
                     aria-hidden="true"
+                    @click="showDatePicker = true"
                   />
                   <v-select
                     v-if="isPpr && header.value === 'statusType'"

ppr-ui/src/components/tables/common/TableRow.vue

@@ -25,6 +25,8 @@
             color="primary"
             size="small"
             icon
+            :aria-label="isPpr ? 'Expand Amendments' : 'Expand History'"
+            role="button"
             @click="toggleExpand(item)"
             @mouseover="rollover = true"
             @mouseleave="rollover = false"
@@ -252,14 +254,17 @@
         class="pdf-btn px-0 mt-n3"
         variant="plain"
         :loading="item.path === loadingPDF"
-        @click="downloadPDF(item)"
         aria-label="Download PDF"
+        @click="downloadPDF(item)"
       >
-        <img 
+        <img
           src="@/assets/svgs/pdf-icon-blue.svg"
           role="img"
         >
-        <span class="pl-1" aria-hidden="true">PDF</span>
+        <span
+          class="pl-1"
+          aria-hidden="true"
+        >PDF</span>
       </v-btn>
       <v-tooltip
         v-else-if="!isDraft(item)"
@@ -303,8 +308,8 @@
             v-if="isDraft(item)"
             class="edit-btn"
             color="primary"
-            @click="editDraft(item)"
             aria-label="Edit Button"
+            @click="editDraft(item)"
           >
             <span>Edit</span>
           </v-btn>
@@ -320,19 +325,19 @@
             v-else-if="!isExpired(item) && !isDischarged(item)"
             class="edit-btn"
             color="primary"
+            aria-hidden="false"
+            aria-label="Amend Button"
             @click="handleAction(item, TableActions.AMEND)"
-             aria-hidden="false"
-             aria-label="Amend Button"
           >
             <span>Amend</span>
           </v-btn>
           <v-btn
             v-else
             color="primary"
             class="remove-btn"
+            aria-label="Remove From Table Button"
+            aria-hidden="false"
             @click="handleAction(item, TableActions.REMOVE)"
-             aria-hidden="false"
-             aria-label="Remove From Table Button"
           >
             <span class="fs-12">Remove From Table</span>
           </v-btn>
@@ -471,9 +476,9 @@
           <v-btn
             color="primary"
             class="edit-btn"
-            @click="openMhr(item)"
             aria-hidden="false"
             aria-label="Open Button"
+            @click="openMhr(item)"
           >
             <span>Open</span>
           </v-btn>
@@ -618,9 +623,9 @@
           <v-btn
             color="primary"
             class="edit-btn"
-            @click="openMhr(item)"
             aria-hidden="false"
             aria-label="Edit Button"
+            @click="openMhr(item)"
           >
             <span>Edit</span>
           </v-btn>
@@ -696,7 +701,7 @@ import {
   HomeLocationTypes
 } from '@/enums'
 import { useRegistration } from '@/composables/useRegistration'
-import { useExemptions, useTransferOwners } from '@/composables'
+import { useExemptions, useMhrInformation, useTransferOwners } from '@/composables'
 import moment from 'moment'
 import { storeToRefs } from 'pinia'
 import { QSLockedStateUnitNoteTypes } from '@/resources'
@@ -741,6 +746,7 @@ export default defineComponent({
       securedParties
     } = useRegistration(null)
     const { isTransAffi } = useTransferOwners()
+    const { hasQsTransferOrExemptionBlockingLien } = useMhrInformation()
     const { isExemptionEnabled, isNonResExemptionEnabled, hasChildResExemption } = useExemptions()
 
     const localState = reactive({
@@ -779,7 +785,7 @@ export default defineComponent({
       hasLienForQS: computed(() => {
         return isRoleQualifiedSupplier.value &&
           localState.item.lienRegistrationType &&
-          localState.item.lienRegistrationType !== APIRegistrationTypes.SECURITY_AGREEMENT
+          hasQsTransferOrExemptionBlockingLien.value
       }),
       hasLockedForQS: computed(() => {
        return  hasLockedState(localState.item) && isRoleQualifiedSupplier.value

ppr-ui/src/components/unitNotes/UnitNoteAdd.vue

@@ -136,7 +136,8 @@ export default defineComponent({
           : personGivingNoticeContent
       ),
       isNoticeOfTaxSale: computed((): boolean => props.docType === UnitNoteDocTypes.NOTICE_OF_TAX_SALE),
-      hasNoPersonGivingNotice: props.docType === UnitNoteDocTypes.DECAL_REPLACEMENT || (getMhrUnitNote.value as UnitNoteIF).hasNoPersonGivingNotice || false,
+      hasNoPersonGivingNotice: props.docType === UnitNoteDocTypes.DECAL_REPLACEMENT ||
+        (getMhrUnitNote.value as UnitNoteIF).hasNoPersonGivingNotice || false,
 
       // Remarks
       unitNoteRemarks: (getMhrUnitNote.value as UnitNoteIF).remarks || '',
@@ -176,7 +177,10 @@ export default defineComponent({
 
     onMounted(() => {
       if(props.docType === UnitNoteDocTypes.DECAL_REPLACEMENT) {
-        setValidation(MhrSectVal.UNIT_NOTE_VALID, MhrCompVal.PERSON_GIVING_NOTICE_VALID, localState.hasNoPersonGivingNotice)
+        setValidation(
+          MhrSectVal.UNIT_NOTE_VALID, MhrCompVal.PERSON_GIVING_NOTICE_VALID,
+          localState.hasNoPersonGivingNotice
+        )
         handleStoreUpdate('hasNoPersonGivingNotice', localState.hasNoPersonGivingNotice)
       }
     })

ppr-ui/src/composables/mhrInformation/useMhrInformation.ts

@@ -117,7 +117,38 @@ export const useMhrInformation = () => {
         localState.isFrozenMhr &&
         QSLockedStateUnitNoteTypes.includes(getMhrInformation.value?.frozenDocumentType)
       )
-    })
+    }),
+    /** Returns true when there is a lien present that would block a Qualified Supplier from ALL Registration Types **/
+    hasQsBlockingLien: computed((): boolean => {
+      return [
+        APIRegistrationTypes.SECURITY_AGREEMENT_TAX,
+        APIRegistrationTypes.TRANSITION_SECURITY_AGREEMENT_TAX,
+        APIRegistrationTypes.TRANSITION_MH_TAX
+      ].includes(getLienRegistrationType.value)
+    }),
+    /** Returns true when there is a lien present that would block a Qualified Supplier from Transfers or Exemptions **/
+    hasQsTransferOrExemptionBlockingLien: computed((): boolean => {
+      return localState.hasQsBlockingLien ||
+        [
+          APIRegistrationTypes.SECURITY_AGREEMENT_GOV,
+          APIRegistrationTypes.TRANSITION_SECURITY_AGREEMENT_GOV,
+          APIRegistrationTypes.TRANSITION_MH_GOV,
+          APIRegistrationTypes.MARRIAGE_MH,
+          APIRegistrationTypes.LAND_TAX_LIEN,
+          APIRegistrationTypes.MAINTENANCE_LIEN,
+          APIRegistrationTypes.MANUFACTURED_HOME_NOTICE,
+          APIRegistrationTypes.SALE_OF_GOODS
+        ].includes(getLienRegistrationType.value)
+    }),
+    /** Returns true when there is a lien present that would block a Qualified Supplier from Transport Permits **/
+    hasQsPermitBlockingLien: computed((): boolean => {
+      return localState.hasQsBlockingLien ||
+        [
+          APIRegistrationTypes.LAND_TAX_LIEN,
+          APIRegistrationTypes.MAINTENANCE_LIEN,
+          APIRegistrationTypes.MANUFACTURED_HOME_NOTICE
+        ].includes(getLienRegistrationType.value)
+    }),
   })
 
   /** New Filings / Initializing **/

ppr-ui/src/composables/mhrInformation/useTransportPermits.ts

@@ -18,13 +18,13 @@ import {
   UnitNoteIF
 } from '@/interfaces'
 import {
-  APIRegistrationTypes,
   HomeLocationTypes,
   MhApiStatusTypes,
   UnitNoteDocTypes,
   UnitNoteStatusTypes
 } from '@/enums'
 import { cloneDeep, get, isEqual } from 'lodash'
+import { useMhrInformation } from '@/composables'
 
 // Global constants
 const isChangeLocationActive: Ref<boolean> = ref(false)
@@ -36,7 +36,6 @@ export const useTransportPermits = () => {
     isRoleStaffSbc,
     isRoleStaffReg,
     isRoleQualifiedSupplier,
-    getLienRegistrationType,
     getMhrUnitNotes,
     getMhrTransportPermit,
     getMhrOriginalTransportPermit,
@@ -54,6 +53,8 @@ export const useTransportPermits = () => {
     setMhrTransportPermitLocationChangeType
   } = useStore()
 
+  const { hasQsPermitBlockingLien } = useMhrInformation()
+
   /** Returns true when the Mhr Information permitStatus is ACTIVE **/
   const hasActiveTransportPermit: ComputedRef<boolean> = computed((): boolean => {
     return getMhrInformation.value.permitStatus === MhApiStatusTypes.ACTIVE
@@ -143,24 +144,20 @@ export const useTransportPermits = () => {
       .includes(newLocation)
   }
 
-  const isTransportPermitDisabled = computed((): boolean =>
+  const isTransportPermitDisabled = computed((): boolean => {
     // QS or SBC role check
-    (isRoleQualifiedSupplier.value || isRoleStaffSbc.value) &&
-    // PPR Liens check
-    ([APIRegistrationTypes.LAND_TAX_LIEN,
-    APIRegistrationTypes.MAINTENANCE_LIEN,
-    APIRegistrationTypes.MANUFACTURED_HOME_NOTICE]
-      .includes(getLienRegistrationType.value as APIRegistrationTypes) ||
-    // Unit Notes check
+    return (isRoleQualifiedSupplier.value || isRoleStaffSbc.value) &&
+      // PPR Liens check
+      ((isRoleQualifiedSupplier.value && hasQsPermitBlockingLien.value) ||
+      // Unit Notes check
       getMhrUnitNotes.value
         .filter(note => note.status === UnitNoteStatusTypes.ACTIVE)
         .some(note => [
           UnitNoteDocTypes.NOTICE_OF_TAX_SALE,
           UnitNoteDocTypes.CONFIDENTIAL_NOTE,
           UnitNoteDocTypes.RESTRAINING_ORDER
-        ].includes(note.documentType))
-    )
-  )
+        ].includes(note.documentType)))
+    })
 
   /**
    * Check if Amend or Cancel Transport Permit is allowed for Exempt MHR based on few conditions.

ppr-ui/src/enums/registrationTypes.ts

@@ -57,7 +57,15 @@ export enum APIRegistrationTypes {
   MHR_CORRECTION_STAFF = 'REGC_STAFF',
   MHR_CORRECTION_CLIENT = 'REGC_CLIENT',
   MHR_PUBLIC_AMENDMENT = 'PUBA',
-  MHR_RE_REGISTRATION = 'EXRE'
+  MHR_RE_REGISTRATION = 'EXRE',
+  // Secured Party is the Crown
+  SECURITY_AGREEMENT_GOV = 'SA_GOV',
+  TRANSITION_SECURITY_AGREEMENT_GOV = 'TA_GOV',
+  TRANSITION_MH_GOV = 'TM_GOV',
+  // Provincial Ministry tax branch
+  SECURITY_AGREEMENT_TAX = 'SA_TAX',
+  TRANSITION_SECURITY_AGREEMENT_TAX = 'TA_TAX',
+  TRANSITION_MH_TAX = 'TM_TAX'
 }
 
 export enum UIRegistrationTypes {

ppr-ui/src/utils/axios-base.ts

@@ -0,0 +1,25 @@
+import Axios from 'axios'
+import * as Sentry from '@sentry/browser'
+
+const axios = Axios.create()
+
+axios.interceptors.request.use(
+  config => {
+    config.headers['x-apikey'] = sessionStorage.getItem('PPR_API_KEY')
+    return config
+  },
+  error => {
+    // console.log('axios interceptor set request headers error: ' + error)
+    Promise.reject(error)
+  }
+)
+
+axios.interceptors.response.use(
+  response => response,
+  error => {
+    Sentry.captureException(error)
+    return Promise.reject(error)
+  }
+)
+
+export { axios }

ppr-ui/src/utils/ltsa-api-helper.ts

@@ -1,5 +1,5 @@
 // Libraries
-import { axios } from '@/utils/axios-ppr'
+import { axios } from '@/utils/axios-base'
 import { StatusCodes } from 'http-status-codes'
 import { ErrorCategories } from '@/enums'
 import { LtsaDetailsIF, TitleSummariesIF } from '@/interfaces/ltsa-api-interfaces'