Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add payment info for Unit Note submission #1598

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

dimak1
Copy link
Collaborator

@dimak1 dimak1 commented Oct 24, 2023

Issue #:

Description of changes:

  • Add payment info as request param to Unit Note submission API call

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@dimak1
Copy link
Collaborator Author

dimak1 commented Oct 24, 2023

/gcbrun

@dimak1 dimak1 added the Bugfix label Oct 24, 2023
Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1598-ie0orxim.web.app

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1598 (538c007) into main (9255e77) will increase coverage by 4.92%.
Report is 304 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1598      +/-   ##
==========================================
+ Coverage   72.35%   77.27%   +4.92%     
==========================================
  Files         307      379      +72     
  Lines       12767     7015    -5752     
  Branches     2630     1120    -1510     
==========================================
- Hits         9237     5421    -3816     
+ Misses       3518     1562    -1956     
- Partials       12       32      +20     
Flag Coverage Δ
pprui 77.27% <ø> (+4.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ppr-ui/src/App.vue 100.00% <ø> (+56.78%) ⬆️
ppr-ui/src/components/collateral/Collateral.vue 100.00% <ø> (+10.97%) ⬆️
...nents/collateral/generalCollateral/GenColAmend.vue 100.00% <ø> (+18.00%) ⬆️
...onents/collateral/generalCollateral/GenColEdit.vue 100.00% <ø> (+15.15%) ⬆️
...nts/collateral/generalCollateral/GenColSummary.vue 100.00% <ø> (+8.00%) ⬆️
...collateral/generalCollateral/GeneralCollateral.vue 100.00% <ø> (+6.66%) ⬆️
...ts/collateral/vehicleCollateral/EditCollateral.vue 100.00% <ø> (+22.58%) ⬆️
...collateral/vehicleCollateral/VehicleCollateral.vue 100.00% <ø> (+19.41%) ⬆️
...cleCollateral/factories/useCollateralValidation.ts 71.42% <ø> (ø)
...llateral/vehicleCollateral/factories/useVehicle.ts 70.14% <ø> (-0.91%) ⬇️
... and 37 more

... and 278 files with indirect coverage changes

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dimak1 dimak1 merged commit 1bc668d into bcgov:main Oct 24, 2023
7 checks passed
@dimak1 dimak1 deleted the fix/unit-note-payment branch October 24, 2023 20:18
RuoxuanPengBC pushed a commit to RuoxuanPengBC/ppr that referenced this pull request Oct 25, 2023
* Add payment info for Unit Notes submission
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants