Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the fee amounts of Restraining Order, Confidential Note, Publi… #1599

Merged

Conversation

RuoxuanPengBC
Copy link
Contributor

@RuoxuanPengBC RuoxuanPengBC commented Oct 24, 2023

Issue #: /bcgov/entity#18151

Description of changes:

Update to Restraining Order, Public Note, and Confidential Note unit note fee amount

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@RuoxuanPengBC
Copy link
Contributor Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1599-llp6qnn3.web.app

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1599 (58bac63) into main (9255e77) will increase coverage by 4.92%.
Report is 305 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1599      +/-   ##
==========================================
+ Coverage   72.35%   77.28%   +4.92%     
==========================================
  Files         307      379      +72     
  Lines       12767     7016    -5751     
  Branches     2630     1120    -1510     
==========================================
- Hits         9237     5422    -3815     
+ Misses       3518     1562    -1956     
- Partials       12       32      +20     
Flag Coverage Δ
pprui 77.28% <ø> (+4.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ppr-ui/src/App.vue 100.00% <ø> (+56.78%) ⬆️
ppr-ui/src/components/collateral/Collateral.vue 100.00% <ø> (+10.97%) ⬆️
...nents/collateral/generalCollateral/GenColAmend.vue 100.00% <ø> (+18.00%) ⬆️
...onents/collateral/generalCollateral/GenColEdit.vue 100.00% <ø> (+15.15%) ⬆️
...nts/collateral/generalCollateral/GenColSummary.vue 100.00% <ø> (+8.00%) ⬆️
...collateral/generalCollateral/GeneralCollateral.vue 100.00% <ø> (+6.66%) ⬆️
...ts/collateral/vehicleCollateral/EditCollateral.vue 100.00% <ø> (+22.58%) ⬆️
...collateral/vehicleCollateral/VehicleCollateral.vue 100.00% <ø> (+19.41%) ⬆️
...cleCollateral/factories/useCollateralValidation.ts 71.42% <ø> (ø)
...llateral/vehicleCollateral/factories/useVehicle.ts 70.14% <ø> (-0.91%) ⬇️
... and 37 more

... and 278 files with indirect coverage changes

@dimak1 dimak1 merged commit 3e3a60b into bcgov:main Oct 25, 2023
RuoxuanPengBC added a commit to RuoxuanPengBC/ppr that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants