-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Residential Exemption with Lien #1621
Conversation
/gcbrun |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1621 +/- ##
==========================================
+ Coverage 72.35% 77.29% +4.94%
==========================================
Files 307 381 +74
Lines 12767 7052 -5715
Branches 2630 1129 -1501
==========================================
- Hits 9237 5451 -3786
+ Misses 3518 1569 -1949
- Partials 12 32 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Temporary Url for review: https://bcregistry-assets-dev--pr-1621-rev6egpo.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!!!
/gcbrun |
Temporary Url for review: https://bcregistry-assets-dev--pr-1621-rev6egpo.web.app |
@cameron-eyds please have another look - I did some refactoring (LienAlert component) and added new code. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New commit looks great 🦖
Issue #:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).