Delay app mount to allow for auth data #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimak1
approved these changes
Dec 5, 2023
| @@ -235,7 +235,7 @@ export default defineComponent({ | |||
| // When we are authenticated, allow time for session storage propagation from auth, then initialize application | |||
| // (since we won't get the event from Signin component) | |||
| if (isAuthenticated.value) { | |||
| onProfileReady(true) | |||
| setTimeout(() => { onProfileReady(true) }, 3000) | |||
There was a problem hiding this comment.
3s? Would it slow down the loading of the page or in the background?
There was a problem hiding this comment.
It would be the overlay state, the app loads up but the contents (ie components in the router-view) are on a delay.
The jist: SbcHeader, the auth common component kicks off some auth related fetching/storing etc when it's mounted. We are giving it some time before rendering everything inside the router-view and proceeding with some other functionality that relies on that info from Auth being in the store.
There was a problem hiding this comment.
I'll probably reduce to 1s, just wanted to confirm it was the issue first.
doug-lovett
reviewed
Dec 5, 2023
| <h3 class="text-center mb-2"> | ||
| When B.C. Based Businesses Must be in Active Status | ||
| </h3> | ||
| <p><b>New owners:</b> Must be active at the time of registration.</p> | ||
| <p> | ||
| If you are adding a B.C. based business as a new owner, the business <b>must be active on the | ||
| B.C Corporate Register at the time of the registration.</b> | ||
| B.C Corporate Register at the time of the registration.</b> |
There was a problem hiding this comment.
Should this be "B.C." instead of "B.C"?
There was a problem hiding this comment.
Indeed, I imagine it should, good eye, good thing this line was linted 😁
Thank you!
doug-lovett
approved these changes
Dec 5, 2023
cameron-eyds
force-pushed
the
auth-timing-issue
branch
from
868865f to
c72ed6f
Compare
|
Merging, as it was just a codecov upload failure in the CI. |
cameron-eyds
merged commit a3be023
into
bcgov:Vue3-Upgrade-Feature-Branch
3 of 4 checks passed
cameron-eyds
added a commit
that referenced
this pull request
Dec 8, 2023
* Ongoing PPR Unit testing (#1626) * Vue3 Build (#1594) * Vue3/Vuetify3/Vite-Build * wip: Up to Searches * wip: Search Features * Wip: PPR Search Done - Onto Mhr Search Results * Refactors generally completed on PPR/MHR Searches and history * CI Updates * update dockerfil * revert docker file udpates * docker change reverse * Docker update * docker node version update * last attempt at ci build * vue-affix removal * Lint Fixes * lint config updates * Modernized Linting for Vue and Typescript -- Applied non functional fixes * Updated vue declaration * Vuetify and component updates - PRR (#1609) * base dialog and Staff Payment instances updated * ongoing PPR Table work * Ongoin PPR Registrations/Amendment updates * Ongoing PPR Reg - Includes stepper, footers, Bus Search, Base Address * Ppr Registrations Happy Path * Chips and other misc fixes for Amendments * Vuetify Fixes for MHR and Misc Features (#1615) * Mhr Registrations Happy Path * Ongoing Registration Table Improvements * User access Start, some more table clean up * User Access Fixes + more table updates * Cleaned up Tables Sorting * Further Transfer and Unit Note Adjustments * Masking fixes and replacements * Date Pickers and misc styling adjustments * Lint Sweeps and camelCase enforcement * Reg Table Fix and command revert * Further DatePicker Updates * ViTest: Unit Testing Setup/Config/Utils and Ongoing Refactoring (#1623) * Ongoing Unit Test fixes * Ongoing PPR Test fixes - Includes base setup - solves most complexity - now test fixes * more test config updates and unit test fixes * button-footer rework * Further Testing updates - Up to Debtors * continued testing updates DischargeReg * Tests up to EditTrust and more cleanup * PR CleanUP * Few more tests - up to FeeSummary * FeeSummary test * Lint update * fee summary file clean up * Sync Clean Up * Ongoing test work * Delete .idea directory * PPR Unit Testing Part 3 (#1631) * Ongoing tests: nearly complete * Only Table row and reg wrapper to complete * setup adjustments * Reg Wrapper and Fetching updates * ppr testing finalized * jest clean up and terminal clean up * Update MHR unit tests - Part 1 (#1630) Update unit tests * Vue Fold in Prep: Linting Fixes (#1633) * ongoing Linting * Lint Fixes * no gutters update * MakeModel Test Fix * MHR Test Fixes, Misc UI fixes (#1636) * Test Updates, Misc UI fixes * ts config clean up * Update Unit Tests - Part 2 (#1635) * Further updated to unit tests * More unit test updates * Further unit test updates * More unit test updates * Fix errors in Dashboard test by mocking api calls * Fix Signout test from error * Fix some of Typescript errors * 17701 Misc MHR Clean Up (#1638) * Misc Ui clean up * remove dev code * remove more dev code * Fixes after Rebase * Fix unit tests, small cleanup (#1640) * Delay app mount to allow for auth data (#1641) * Delay app mount to allow for auth data * spacing fix * optional chain doc for testing env * linting fixes * test fix and spelling correction * Console cleanup * Fix Lien Alert message for QS (#1643) * Fix Lien Alert message for QS * Version update * SbcCC Version Updates + Lien/Locked Updates (#1645) * Authentication Flow updates * minor syntax fix and error handling * Remove extra console * RL Collateral Selector fix * Axios version and interceptor upgrades (#1646) * sbc-cc updates (for axios V) and axios interceptor updates * Version bump * Fix Lien Alert msg (#1648) * Home Owners styling and Transfer Bugs (#1649) * Home Owners Styling and Bug fixes * Pr Updates --------- Co-authored-by: Dima K <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity###
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).