Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account reg summary add legacy registration indicator. #1803

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Account reg summary add legacy registration indicator. #1803

merged 2 commits into from
Mar 28, 2024

Conversation

doug-lovett
Copy link
Collaborator

@doug-lovett doug-lovett commented Mar 28, 2024

Issue #: /bcgov/entity#20499

Description of changes:

  • PPR API GET registration summary add property named "legacy" to indicate registration was created in the legacy application.
  • MHR API GET registration summary add property named "legacy" to indicate registration was created in the legacy application.
  • Update unit tests.

Issue #: /bcgov/entity#20501

Description of changes:

  • Correction/amendment location data validation skip tax certification information check.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@doug-lovett doug-lovett added MHR API MHR API changes PPR API labels Mar 28, 2024
@doug-lovett doug-lovett self-assigned this Mar 28, 2024
Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@doug-lovett
Copy link
Collaborator Author

@cameron-eyds I added a small change for 20501 if you could please re-review.

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@doug-lovett doug-lovett merged commit 331d25f into bcgov:main Mar 28, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MHR API MHR API changes PPR API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants