Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Transfer Updates to Transfer Details & Review #1846

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

dimak1
Copy link
Collaborator

@dimak1 dimak1 commented Apr 24, 2024

Issue #:

Description of changes:

  • Updates to Misc Transfer Types without Bill of Sale
  • See ticket for details

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@dimak1 dimak1 self-assigned this Apr 24, 2024
@dimak1 dimak1 changed the title Feat/misc transfer updates Misc Transfer Updates to Transfer Details & Review Apr 24, 2024
@dimak1 dimak1 force-pushed the feat/misc-transfer-updates branch from f312079 to ae18824 Compare April 24, 2024 19:53
@dimak1 dimak1 marked this pull request as ready for review April 24, 2024 19:55
@dimak1
Copy link
Collaborator Author

dimak1 commented Apr 24, 2024

/gcbrun

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1846-l630su9i.web.app

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dimak1 dimak1 force-pushed the feat/misc-transfer-updates branch from 42f2f60 to feac6da Compare April 26, 2024 20:59
@dimak1
Copy link
Collaborator Author

dimak1 commented Apr 26, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1846-l630su9i.web.app

@dimak1 dimak1 merged commit 11536fe into bcgov:main Apr 26, 2024
4 of 5 checks passed
@dimak1 dimak1 deleted the feat/misc-transfer-updates branch April 26, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants