Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer Bugs & Validation Updates #1851

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

cameron-eyds
Copy link
Collaborator

Issue #: /bcgov/entity#20884

Description of changes:
*Transfer Related bugs:

  • Fixes added owner removal following affe
  • Fix pre-populated interest numerator value when applying defaults
  • Update validation for the required removal of all owners in Transfer due to death flows: Changed Validation message to reflect this.
  • Apply mapping for Storage Shed type in Non Res Exmeption

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@cameron-eyds cameron-eyds self-assigned this Apr 29, 2024
@cameron-eyds cameron-eyds force-pushed the 20884-Misc-Transfer-Bugs branch from 4f8c70b to cbcb94a Compare April 29, 2024 19:45
@cameron-eyds
Copy link
Collaborator Author

/gcbrun

Copy link
Collaborator

@dimak1 dimak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1851-u46z85y6.web.app

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cameron-eyds cameron-eyds merged commit b08a96a into bcgov:main Apr 29, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants