Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Draft MHR Corrections #1858

Merged
merged 4 commits into from
May 8, 2024
Merged

Conversation

dimak1
Copy link
Collaborator

@dimak1 dimak1 commented May 6, 2024

Issue #:

Description of changes:

  • Save and Retrieve Draft MHR Corrections
  • Handle stale drafts on save, on save and resume, handle stale registrations

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@dimak1 dimak1 requested review from doug-lovett and cameron-eyds May 6, 2024 16:29
@dimak1 dimak1 self-assigned this May 6, 2024
Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dimak1
Copy link
Collaborator Author

dimak1 commented May 6, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1858-m6z907xf.web.app

@dimak1
Copy link
Collaborator Author

dimak1 commented May 7, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1858-m6z907xf.web.app

@dimak1 dimak1 force-pushed the feat/mhr-corrections-drafts branch from 396c416 to 89e523b Compare May 8, 2024 13:11
@dimak1
Copy link
Collaborator Author

dimak1 commented May 8, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1858-m6z907xf.web.app

@dimak1 dimak1 merged commit 03b827f into bcgov:main May 8, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants