Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel Transport Permit framework #1868

Merged
merged 8 commits into from
May 13, 2024

Conversation

dimak1
Copy link
Collaborator

@dimak1 dimak1 commented May 11, 2024

Issue #:

Description of changes:

  • Feature Flag mhr-cancel-transport-permit-enabled
  • Cancel Transport Permit setup
  • Small refactor of HomeLocationReview
  • Render Cancelled and Restored Locations

Screenshot 2024-05-10 at 14 52 52

Screenshot 2024-05-10 at 14 53 01

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@dimak1 dimak1 added the MHR Transport Permit Transport Permit Registration label May 11, 2024
@dimak1 dimak1 self-assigned this May 11, 2024
@dimak1 dimak1 force-pushed the feat/cancel-permit-framework branch from 2dc25b9 to 918ef76 Compare May 11, 2024 22:01
Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
As always, due to the potential impacts on MhRegistrations, MhrCorrections/Amendments and Transport Permits, would be good to call out for regression testing on these flows.

@dimak1
Copy link
Collaborator Author

dimak1 commented May 13, 2024

Looks good! As always, due to the potential impacts on MhRegistrations, MhrCorrections/Amendments and Transport Permits, would be good to call out for regression testing on these flows.

@cameron-eyds thanks, yea for sure, I will let Divya know

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dimak1 dimak1 merged commit d014fe0 into bcgov:main May 13, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MHR Transport Permit Transport Permit Registration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants