Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and Submit Cancel Transport Permit #1875

Merged
merged 6 commits into from
May 17, 2024

Conversation

dimak1
Copy link
Collaborator

@dimak1 dimak1 commented May 15, 2024

Issue #:

Description of changes:

  • Review and Confirm page update
  • Update validations
  • Submission of Cancel Transport Permits
  • Unit tests

Screenshot 2024-05-15 at 08 12 33

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@dimak1 dimak1 added the MHR Transport Permit Transport Permit Registration label May 15, 2024
@dimak1 dimak1 self-assigned this May 15, 2024
@dimak1
Copy link
Collaborator Author

dimak1 commented May 15, 2024

/gcbrun

@dimak1 dimak1 changed the title Submit Cancel Transport Permit Review and Submit Cancel Transport Permit May 15, 2024
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1875-wvuwl8y4.web.app

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dimak1 dimak1 force-pushed the feat/submit-cancel-permit branch from da3bad4 to 1fde607 Compare May 17, 2024 15:51
@dimak1
Copy link
Collaborator Author

dimak1 commented May 17, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1875-wvuwl8y4.web.app

@dimak1 dimak1 force-pushed the feat/submit-cancel-permit branch from 1fde607 to 0528438 Compare May 17, 2024 17:14
@dimak1 dimak1 merged commit 3931a37 into bcgov:main May 17, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MHR Transport Permit Transport Permit Registration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants