Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHR Re-Registrations Framework #1905

Merged
merged 7 commits into from
Jun 3, 2024
Merged

Conversation

dimak1
Copy link
Collaborator

@dimak1 dimak1 commented May 30, 2024

Issue #:

Description of changes:

  • Setup new flow for MHR Re-Registration
  • Updated Badge for new flow
  • Tombstone, FeeSummary
  • Unit Tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@dimak1
Copy link
Collaborator Author

dimak1 commented May 30, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1905-902g8i2q.web.app

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@dimak1 dimak1 force-pushed the feat/re-register-home branch from 6639214 to 9259231 Compare June 3, 2024 10:28
@dimak1
Copy link
Collaborator Author

dimak1 commented Jun 3, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1905-902g8i2q.web.app

1 similar comment
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1905-902g8i2q.web.app

@dimak1 dimak1 merged commit 6345c20 into bcgov:main Jun 3, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants